server_test.go 105 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516351735183519352035213522352335243525352635273528352935303531353235333534353535363537353835393540354135423543354435453546354735483549355035513552355335543555355635573558355935603561356235633564356535663567356835693570357135723573357435753576357735783579358035813582358335843585358635873588358935903591359235933594359535963597359835993600360136023603360436053606360736083609361036113612361336143615361636173618361936203621362236233624362536263627362836293630363136323633363436353636363736383639364036413642364336443645364636473648364936503651365236533654365536563657365836593660366136623663366436653666366736683669367036713672367336743675367636773678367936803681368236833684368536863687368836893690369136923693369436953696369736983699370037013702370337043705370637073708370937103711371237133714371537163717371837193720372137223723372437253726372737283729373037313732373337343735373637373738373937403741374237433744374537463747374837493750375137523753375437553756375737583759376037613762376337643765376637673768376937703771377237733774377537763777377837793780378137823783378437853786378737883789379037913792379337943795379637973798379938003801380238033804380538063807380838093810381138123813381438153816381738183819382038213822382338243825382638273828382938303831383238333834383538363837383838393840384138423843384438453846384738483849385038513852
  1. // Copyright 2014 The Go Authors. All rights reserved.
  2. // Use of this source code is governed by a BSD-style
  3. // license that can be found in the LICENSE file.
  4. package http2
  5. import (
  6. "bytes"
  7. "crypto/tls"
  8. "errors"
  9. "flag"
  10. "fmt"
  11. "io"
  12. "io/ioutil"
  13. "log"
  14. "net"
  15. "net/http"
  16. "net/http/httptest"
  17. "os"
  18. "os/exec"
  19. "reflect"
  20. "runtime"
  21. "strconv"
  22. "strings"
  23. "sync"
  24. "sync/atomic"
  25. "testing"
  26. "time"
  27. "golang.org/x/net/http2/hpack"
  28. )
  29. var stderrVerbose = flag.Bool("stderr_verbose", false, "Mirror verbosity to stderr, unbuffered")
  30. func stderrv() io.Writer {
  31. if *stderrVerbose {
  32. return os.Stderr
  33. }
  34. return ioutil.Discard
  35. }
  36. type serverTester struct {
  37. cc net.Conn // client conn
  38. t testing.TB
  39. ts *httptest.Server
  40. fr *Framer
  41. serverLogBuf bytes.Buffer // logger for httptest.Server
  42. logFilter []string // substrings to filter out
  43. scMu sync.Mutex // guards sc
  44. sc *serverConn
  45. hpackDec *hpack.Decoder
  46. decodedHeaders [][2]string
  47. // If http2debug!=2, then we capture Frame debug logs that will be written
  48. // to t.Log after a test fails. The read and write logs use separate locks
  49. // and buffers so we don't accidentally introduce synchronization between
  50. // the read and write goroutines, which may hide data races.
  51. frameReadLogMu sync.Mutex
  52. frameReadLogBuf bytes.Buffer
  53. frameWriteLogMu sync.Mutex
  54. frameWriteLogBuf bytes.Buffer
  55. // writing headers:
  56. headerBuf bytes.Buffer
  57. hpackEnc *hpack.Encoder
  58. }
  59. func init() {
  60. testHookOnPanicMu = new(sync.Mutex)
  61. goAwayTimeout = 25 * time.Millisecond
  62. }
  63. func resetHooks() {
  64. testHookOnPanicMu.Lock()
  65. testHookOnPanic = nil
  66. testHookOnPanicMu.Unlock()
  67. }
  68. type serverTesterOpt string
  69. var optOnlyServer = serverTesterOpt("only_server")
  70. var optQuiet = serverTesterOpt("quiet_logging")
  71. var optFramerReuseFrames = serverTesterOpt("frame_reuse_frames")
  72. func newServerTester(t testing.TB, handler http.HandlerFunc, opts ...interface{}) *serverTester {
  73. resetHooks()
  74. ts := httptest.NewUnstartedServer(handler)
  75. tlsConfig := &tls.Config{
  76. InsecureSkipVerify: true,
  77. NextProtos: []string{NextProtoTLS},
  78. }
  79. var onlyServer, quiet, framerReuseFrames bool
  80. h2server := new(Server)
  81. for _, opt := range opts {
  82. switch v := opt.(type) {
  83. case func(*tls.Config):
  84. v(tlsConfig)
  85. case func(*httptest.Server):
  86. v(ts)
  87. case func(*Server):
  88. v(h2server)
  89. case serverTesterOpt:
  90. switch v {
  91. case optOnlyServer:
  92. onlyServer = true
  93. case optQuiet:
  94. quiet = true
  95. case optFramerReuseFrames:
  96. framerReuseFrames = true
  97. }
  98. case func(net.Conn, http.ConnState):
  99. ts.Config.ConnState = v
  100. default:
  101. t.Fatalf("unknown newServerTester option type %T", v)
  102. }
  103. }
  104. ConfigureServer(ts.Config, h2server)
  105. st := &serverTester{
  106. t: t,
  107. ts: ts,
  108. }
  109. st.hpackEnc = hpack.NewEncoder(&st.headerBuf)
  110. st.hpackDec = hpack.NewDecoder(initialHeaderTableSize, st.onHeaderField)
  111. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  112. if quiet {
  113. ts.Config.ErrorLog = log.New(ioutil.Discard, "", 0)
  114. } else {
  115. ts.Config.ErrorLog = log.New(io.MultiWriter(stderrv(), twriter{t: t, st: st}, &st.serverLogBuf), "", log.LstdFlags)
  116. }
  117. ts.StartTLS()
  118. if VerboseLogs {
  119. t.Logf("Running test server at: %s", ts.URL)
  120. }
  121. testHookGetServerConn = func(v *serverConn) {
  122. st.scMu.Lock()
  123. defer st.scMu.Unlock()
  124. st.sc = v
  125. }
  126. log.SetOutput(io.MultiWriter(stderrv(), twriter{t: t, st: st}))
  127. if !onlyServer {
  128. cc, err := tls.Dial("tcp", ts.Listener.Addr().String(), tlsConfig)
  129. if err != nil {
  130. t.Fatal(err)
  131. }
  132. st.cc = cc
  133. st.fr = NewFramer(cc, cc)
  134. if framerReuseFrames {
  135. st.fr.SetReuseFrames()
  136. }
  137. if !logFrameReads && !logFrameWrites {
  138. st.fr.debugReadLoggerf = func(m string, v ...interface{}) {
  139. m = time.Now().Format("2006-01-02 15:04:05.999999999 ") + strings.TrimPrefix(m, "http2: ") + "\n"
  140. st.frameReadLogMu.Lock()
  141. fmt.Fprintf(&st.frameReadLogBuf, m, v...)
  142. st.frameReadLogMu.Unlock()
  143. }
  144. st.fr.debugWriteLoggerf = func(m string, v ...interface{}) {
  145. m = time.Now().Format("2006-01-02 15:04:05.999999999 ") + strings.TrimPrefix(m, "http2: ") + "\n"
  146. st.frameWriteLogMu.Lock()
  147. fmt.Fprintf(&st.frameWriteLogBuf, m, v...)
  148. st.frameWriteLogMu.Unlock()
  149. }
  150. st.fr.logReads = true
  151. st.fr.logWrites = true
  152. }
  153. }
  154. return st
  155. }
  156. func (st *serverTester) closeConn() {
  157. st.scMu.Lock()
  158. defer st.scMu.Unlock()
  159. st.sc.conn.Close()
  160. }
  161. func (st *serverTester) addLogFilter(phrase string) {
  162. st.logFilter = append(st.logFilter, phrase)
  163. }
  164. func (st *serverTester) stream(id uint32) *stream {
  165. ch := make(chan *stream, 1)
  166. st.sc.serveMsgCh <- func(int) {
  167. ch <- st.sc.streams[id]
  168. }
  169. return <-ch
  170. }
  171. func (st *serverTester) streamState(id uint32) streamState {
  172. ch := make(chan streamState, 1)
  173. st.sc.serveMsgCh <- func(int) {
  174. state, _ := st.sc.state(id)
  175. ch <- state
  176. }
  177. return <-ch
  178. }
  179. // loopNum reports how many times this conn's select loop has gone around.
  180. func (st *serverTester) loopNum() int {
  181. lastc := make(chan int, 1)
  182. st.sc.serveMsgCh <- func(loopNum int) {
  183. lastc <- loopNum
  184. }
  185. return <-lastc
  186. }
  187. // awaitIdle heuristically awaits for the server conn's select loop to be idle.
  188. // The heuristic is that the server connection's serve loop must schedule
  189. // 50 times in a row without any channel sends or receives occurring.
  190. func (st *serverTester) awaitIdle() {
  191. remain := 50
  192. last := st.loopNum()
  193. for remain > 0 {
  194. n := st.loopNum()
  195. if n == last+1 {
  196. remain--
  197. } else {
  198. remain = 50
  199. }
  200. last = n
  201. }
  202. }
  203. func (st *serverTester) Close() {
  204. if st.t.Failed() {
  205. st.frameReadLogMu.Lock()
  206. if st.frameReadLogBuf.Len() > 0 {
  207. st.t.Logf("Framer read log:\n%s", st.frameReadLogBuf.String())
  208. }
  209. st.frameReadLogMu.Unlock()
  210. st.frameWriteLogMu.Lock()
  211. if st.frameWriteLogBuf.Len() > 0 {
  212. st.t.Logf("Framer write log:\n%s", st.frameWriteLogBuf.String())
  213. }
  214. st.frameWriteLogMu.Unlock()
  215. // If we failed already (and are likely in a Fatal,
  216. // unwindowing), force close the connection, so the
  217. // httptest.Server doesn't wait forever for the conn
  218. // to close.
  219. if st.cc != nil {
  220. st.cc.Close()
  221. }
  222. }
  223. st.ts.Close()
  224. if st.cc != nil {
  225. st.cc.Close()
  226. }
  227. log.SetOutput(os.Stderr)
  228. }
  229. // greet initiates the client's HTTP/2 connection into a state where
  230. // frames may be sent.
  231. func (st *serverTester) greet() {
  232. st.greetAndCheckSettings(func(Setting) error { return nil })
  233. }
  234. func (st *serverTester) greetAndCheckSettings(checkSetting func(s Setting) error) {
  235. st.writePreface()
  236. st.writeInitialSettings()
  237. st.wantSettings().ForeachSetting(checkSetting)
  238. st.writeSettingsAck()
  239. // The initial WINDOW_UPDATE and SETTINGS ACK can come in any order.
  240. var gotSettingsAck bool
  241. var gotWindowUpdate bool
  242. for i := 0; i < 2; i++ {
  243. f, err := st.readFrame()
  244. if err != nil {
  245. st.t.Fatal(err)
  246. }
  247. switch f := f.(type) {
  248. case *SettingsFrame:
  249. if !f.Header().Flags.Has(FlagSettingsAck) {
  250. st.t.Fatal("Settings Frame didn't have ACK set")
  251. }
  252. gotSettingsAck = true
  253. case *WindowUpdateFrame:
  254. if f.FrameHeader.StreamID != 0 {
  255. st.t.Fatalf("WindowUpdate StreamID = %d; want 0", f.FrameHeader.StreamID)
  256. }
  257. incr := uint32((&Server{}).initialConnRecvWindowSize() - initialWindowSize)
  258. if f.Increment != incr {
  259. st.t.Fatalf("WindowUpdate increment = %d; want %d", f.Increment, incr)
  260. }
  261. gotWindowUpdate = true
  262. default:
  263. st.t.Fatalf("Wanting a settings ACK or window update, received a %T", f)
  264. }
  265. }
  266. if !gotSettingsAck {
  267. st.t.Fatalf("Didn't get a settings ACK")
  268. }
  269. if !gotWindowUpdate {
  270. st.t.Fatalf("Didn't get a window update")
  271. }
  272. }
  273. func (st *serverTester) writePreface() {
  274. n, err := st.cc.Write(clientPreface)
  275. if err != nil {
  276. st.t.Fatalf("Error writing client preface: %v", err)
  277. }
  278. if n != len(clientPreface) {
  279. st.t.Fatalf("Writing client preface, wrote %d bytes; want %d", n, len(clientPreface))
  280. }
  281. }
  282. func (st *serverTester) writeInitialSettings() {
  283. if err := st.fr.WriteSettings(); err != nil {
  284. st.t.Fatalf("Error writing initial SETTINGS frame from client to server: %v", err)
  285. }
  286. }
  287. func (st *serverTester) writeSettingsAck() {
  288. if err := st.fr.WriteSettingsAck(); err != nil {
  289. st.t.Fatalf("Error writing ACK of server's SETTINGS: %v", err)
  290. }
  291. }
  292. func (st *serverTester) writeHeaders(p HeadersFrameParam) {
  293. if err := st.fr.WriteHeaders(p); err != nil {
  294. st.t.Fatalf("Error writing HEADERS: %v", err)
  295. }
  296. }
  297. func (st *serverTester) writePriority(id uint32, p PriorityParam) {
  298. if err := st.fr.WritePriority(id, p); err != nil {
  299. st.t.Fatalf("Error writing PRIORITY: %v", err)
  300. }
  301. }
  302. func (st *serverTester) encodeHeaderField(k, v string) {
  303. err := st.hpackEnc.WriteField(hpack.HeaderField{Name: k, Value: v})
  304. if err != nil {
  305. st.t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  306. }
  307. }
  308. // encodeHeaderRaw is the magic-free version of encodeHeader.
  309. // It takes 0 or more (k, v) pairs and encodes them.
  310. func (st *serverTester) encodeHeaderRaw(headers ...string) []byte {
  311. if len(headers)%2 == 1 {
  312. panic("odd number of kv args")
  313. }
  314. st.headerBuf.Reset()
  315. for len(headers) > 0 {
  316. k, v := headers[0], headers[1]
  317. st.encodeHeaderField(k, v)
  318. headers = headers[2:]
  319. }
  320. return st.headerBuf.Bytes()
  321. }
  322. // encodeHeader encodes headers and returns their HPACK bytes. headers
  323. // must contain an even number of key/value pairs. There may be
  324. // multiple pairs for keys (e.g. "cookie"). The :method, :path, and
  325. // :scheme headers default to GET, / and https. The :authority header
  326. // defaults to st.ts.Listener.Addr().
  327. func (st *serverTester) encodeHeader(headers ...string) []byte {
  328. if len(headers)%2 == 1 {
  329. panic("odd number of kv args")
  330. }
  331. st.headerBuf.Reset()
  332. defaultAuthority := st.ts.Listener.Addr().String()
  333. if len(headers) == 0 {
  334. // Fast path, mostly for benchmarks, so test code doesn't pollute
  335. // profiles when we're looking to improve server allocations.
  336. st.encodeHeaderField(":method", "GET")
  337. st.encodeHeaderField(":scheme", "https")
  338. st.encodeHeaderField(":authority", defaultAuthority)
  339. st.encodeHeaderField(":path", "/")
  340. return st.headerBuf.Bytes()
  341. }
  342. if len(headers) == 2 && headers[0] == ":method" {
  343. // Another fast path for benchmarks.
  344. st.encodeHeaderField(":method", headers[1])
  345. st.encodeHeaderField(":scheme", "https")
  346. st.encodeHeaderField(":authority", defaultAuthority)
  347. st.encodeHeaderField(":path", "/")
  348. return st.headerBuf.Bytes()
  349. }
  350. pseudoCount := map[string]int{}
  351. keys := []string{":method", ":scheme", ":authority", ":path"}
  352. vals := map[string][]string{
  353. ":method": {"GET"},
  354. ":scheme": {"https"},
  355. ":authority": {defaultAuthority},
  356. ":path": {"/"},
  357. }
  358. for len(headers) > 0 {
  359. k, v := headers[0], headers[1]
  360. headers = headers[2:]
  361. if _, ok := vals[k]; !ok {
  362. keys = append(keys, k)
  363. }
  364. if strings.HasPrefix(k, ":") {
  365. pseudoCount[k]++
  366. if pseudoCount[k] == 1 {
  367. vals[k] = []string{v}
  368. } else {
  369. // Allows testing of invalid headers w/ dup pseudo fields.
  370. vals[k] = append(vals[k], v)
  371. }
  372. } else {
  373. vals[k] = append(vals[k], v)
  374. }
  375. }
  376. for _, k := range keys {
  377. for _, v := range vals[k] {
  378. st.encodeHeaderField(k, v)
  379. }
  380. }
  381. return st.headerBuf.Bytes()
  382. }
  383. // bodylessReq1 writes a HEADERS frames with StreamID 1 and EndStream and EndHeaders set.
  384. func (st *serverTester) bodylessReq1(headers ...string) {
  385. st.writeHeaders(HeadersFrameParam{
  386. StreamID: 1, // clients send odd numbers
  387. BlockFragment: st.encodeHeader(headers...),
  388. EndStream: true,
  389. EndHeaders: true,
  390. })
  391. }
  392. func (st *serverTester) writeData(streamID uint32, endStream bool, data []byte) {
  393. if err := st.fr.WriteData(streamID, endStream, data); err != nil {
  394. st.t.Fatalf("Error writing DATA: %v", err)
  395. }
  396. }
  397. func (st *serverTester) writeDataPadded(streamID uint32, endStream bool, data, pad []byte) {
  398. if err := st.fr.WriteDataPadded(streamID, endStream, data, pad); err != nil {
  399. st.t.Fatalf("Error writing DATA: %v", err)
  400. }
  401. }
  402. func readFrameTimeout(fr *Framer, wait time.Duration) (Frame, error) {
  403. ch := make(chan interface{}, 1)
  404. go func() {
  405. fr, err := fr.ReadFrame()
  406. if err != nil {
  407. ch <- err
  408. } else {
  409. ch <- fr
  410. }
  411. }()
  412. t := time.NewTimer(wait)
  413. select {
  414. case v := <-ch:
  415. t.Stop()
  416. if fr, ok := v.(Frame); ok {
  417. return fr, nil
  418. }
  419. return nil, v.(error)
  420. case <-t.C:
  421. return nil, errors.New("timeout waiting for frame")
  422. }
  423. }
  424. func (st *serverTester) readFrame() (Frame, error) {
  425. return readFrameTimeout(st.fr, 2*time.Second)
  426. }
  427. func (st *serverTester) wantHeaders() *HeadersFrame {
  428. f, err := st.readFrame()
  429. if err != nil {
  430. st.t.Fatalf("Error while expecting a HEADERS frame: %v", err)
  431. }
  432. hf, ok := f.(*HeadersFrame)
  433. if !ok {
  434. st.t.Fatalf("got a %T; want *HeadersFrame", f)
  435. }
  436. return hf
  437. }
  438. func (st *serverTester) wantContinuation() *ContinuationFrame {
  439. f, err := st.readFrame()
  440. if err != nil {
  441. st.t.Fatalf("Error while expecting a CONTINUATION frame: %v", err)
  442. }
  443. cf, ok := f.(*ContinuationFrame)
  444. if !ok {
  445. st.t.Fatalf("got a %T; want *ContinuationFrame", f)
  446. }
  447. return cf
  448. }
  449. func (st *serverTester) wantData() *DataFrame {
  450. f, err := st.readFrame()
  451. if err != nil {
  452. st.t.Fatalf("Error while expecting a DATA frame: %v", err)
  453. }
  454. df, ok := f.(*DataFrame)
  455. if !ok {
  456. st.t.Fatalf("got a %T; want *DataFrame", f)
  457. }
  458. return df
  459. }
  460. func (st *serverTester) wantSettings() *SettingsFrame {
  461. f, err := st.readFrame()
  462. if err != nil {
  463. st.t.Fatalf("Error while expecting a SETTINGS frame: %v", err)
  464. }
  465. sf, ok := f.(*SettingsFrame)
  466. if !ok {
  467. st.t.Fatalf("got a %T; want *SettingsFrame", f)
  468. }
  469. return sf
  470. }
  471. func (st *serverTester) wantPing() *PingFrame {
  472. f, err := st.readFrame()
  473. if err != nil {
  474. st.t.Fatalf("Error while expecting a PING frame: %v", err)
  475. }
  476. pf, ok := f.(*PingFrame)
  477. if !ok {
  478. st.t.Fatalf("got a %T; want *PingFrame", f)
  479. }
  480. return pf
  481. }
  482. func (st *serverTester) wantGoAway() *GoAwayFrame {
  483. f, err := st.readFrame()
  484. if err != nil {
  485. st.t.Fatalf("Error while expecting a GOAWAY frame: %v", err)
  486. }
  487. gf, ok := f.(*GoAwayFrame)
  488. if !ok {
  489. st.t.Fatalf("got a %T; want *GoAwayFrame", f)
  490. }
  491. return gf
  492. }
  493. func (st *serverTester) wantRSTStream(streamID uint32, errCode ErrCode) {
  494. f, err := st.readFrame()
  495. if err != nil {
  496. st.t.Fatalf("Error while expecting an RSTStream frame: %v", err)
  497. }
  498. rs, ok := f.(*RSTStreamFrame)
  499. if !ok {
  500. st.t.Fatalf("got a %T; want *RSTStreamFrame", f)
  501. }
  502. if rs.FrameHeader.StreamID != streamID {
  503. st.t.Fatalf("RSTStream StreamID = %d; want %d", rs.FrameHeader.StreamID, streamID)
  504. }
  505. if rs.ErrCode != errCode {
  506. st.t.Fatalf("RSTStream ErrCode = %d (%s); want %d (%s)", rs.ErrCode, rs.ErrCode, errCode, errCode)
  507. }
  508. }
  509. func (st *serverTester) wantWindowUpdate(streamID, incr uint32) {
  510. f, err := st.readFrame()
  511. if err != nil {
  512. st.t.Fatalf("Error while expecting a WINDOW_UPDATE frame: %v", err)
  513. }
  514. wu, ok := f.(*WindowUpdateFrame)
  515. if !ok {
  516. st.t.Fatalf("got a %T; want *WindowUpdateFrame", f)
  517. }
  518. if wu.FrameHeader.StreamID != streamID {
  519. st.t.Fatalf("WindowUpdate StreamID = %d; want %d", wu.FrameHeader.StreamID, streamID)
  520. }
  521. if wu.Increment != incr {
  522. st.t.Fatalf("WindowUpdate increment = %d; want %d", wu.Increment, incr)
  523. }
  524. }
  525. func (st *serverTester) wantSettingsAck() {
  526. f, err := st.readFrame()
  527. if err != nil {
  528. st.t.Fatal(err)
  529. }
  530. sf, ok := f.(*SettingsFrame)
  531. if !ok {
  532. st.t.Fatalf("Wanting a settings ACK, received a %T", f)
  533. }
  534. if !sf.Header().Flags.Has(FlagSettingsAck) {
  535. st.t.Fatal("Settings Frame didn't have ACK set")
  536. }
  537. }
  538. func (st *serverTester) wantPushPromise() *PushPromiseFrame {
  539. f, err := st.readFrame()
  540. if err != nil {
  541. st.t.Fatal(err)
  542. }
  543. ppf, ok := f.(*PushPromiseFrame)
  544. if !ok {
  545. st.t.Fatalf("Wanted PushPromise, received %T", ppf)
  546. }
  547. return ppf
  548. }
  549. func TestServer(t *testing.T) {
  550. gotReq := make(chan bool, 1)
  551. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  552. w.Header().Set("Foo", "Bar")
  553. gotReq <- true
  554. })
  555. defer st.Close()
  556. covers("3.5", `
  557. The server connection preface consists of a potentially empty
  558. SETTINGS frame ([SETTINGS]) that MUST be the first frame the
  559. server sends in the HTTP/2 connection.
  560. `)
  561. st.greet()
  562. st.writeHeaders(HeadersFrameParam{
  563. StreamID: 1, // clients send odd numbers
  564. BlockFragment: st.encodeHeader(),
  565. EndStream: true, // no DATA frames
  566. EndHeaders: true,
  567. })
  568. select {
  569. case <-gotReq:
  570. case <-time.After(2 * time.Second):
  571. t.Error("timeout waiting for request")
  572. }
  573. }
  574. func TestServer_Request_Get(t *testing.T) {
  575. testServerRequest(t, func(st *serverTester) {
  576. st.writeHeaders(HeadersFrameParam{
  577. StreamID: 1, // clients send odd numbers
  578. BlockFragment: st.encodeHeader("foo-bar", "some-value"),
  579. EndStream: true, // no DATA frames
  580. EndHeaders: true,
  581. })
  582. }, func(r *http.Request) {
  583. if r.Method != "GET" {
  584. t.Errorf("Method = %q; want GET", r.Method)
  585. }
  586. if r.URL.Path != "/" {
  587. t.Errorf("URL.Path = %q; want /", r.URL.Path)
  588. }
  589. if r.ContentLength != 0 {
  590. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  591. }
  592. if r.Close {
  593. t.Error("Close = true; want false")
  594. }
  595. if !strings.Contains(r.RemoteAddr, ":") {
  596. t.Errorf("RemoteAddr = %q; want something with a colon", r.RemoteAddr)
  597. }
  598. if r.Proto != "HTTP/2.0" || r.ProtoMajor != 2 || r.ProtoMinor != 0 {
  599. t.Errorf("Proto = %q Major=%v,Minor=%v; want HTTP/2.0", r.Proto, r.ProtoMajor, r.ProtoMinor)
  600. }
  601. wantHeader := http.Header{
  602. "Foo-Bar": []string{"some-value"},
  603. }
  604. if !reflect.DeepEqual(r.Header, wantHeader) {
  605. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  606. }
  607. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  608. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  609. }
  610. })
  611. }
  612. func TestServer_Request_Get_PathSlashes(t *testing.T) {
  613. testServerRequest(t, func(st *serverTester) {
  614. st.writeHeaders(HeadersFrameParam{
  615. StreamID: 1, // clients send odd numbers
  616. BlockFragment: st.encodeHeader(":path", "/%2f/"),
  617. EndStream: true, // no DATA frames
  618. EndHeaders: true,
  619. })
  620. }, func(r *http.Request) {
  621. if r.RequestURI != "/%2f/" {
  622. t.Errorf("RequestURI = %q; want /%%2f/", r.RequestURI)
  623. }
  624. if r.URL.Path != "///" {
  625. t.Errorf("URL.Path = %q; want ///", r.URL.Path)
  626. }
  627. })
  628. }
  629. // TODO: add a test with EndStream=true on the HEADERS but setting a
  630. // Content-Length anyway. Should we just omit it and force it to
  631. // zero?
  632. func TestServer_Request_Post_NoContentLength_EndStream(t *testing.T) {
  633. testServerRequest(t, func(st *serverTester) {
  634. st.writeHeaders(HeadersFrameParam{
  635. StreamID: 1, // clients send odd numbers
  636. BlockFragment: st.encodeHeader(":method", "POST"),
  637. EndStream: true,
  638. EndHeaders: true,
  639. })
  640. }, func(r *http.Request) {
  641. if r.Method != "POST" {
  642. t.Errorf("Method = %q; want POST", r.Method)
  643. }
  644. if r.ContentLength != 0 {
  645. t.Errorf("ContentLength = %v; want 0", r.ContentLength)
  646. }
  647. if n, err := r.Body.Read([]byte(" ")); err != io.EOF || n != 0 {
  648. t.Errorf("Read = %d, %v; want 0, EOF", n, err)
  649. }
  650. })
  651. }
  652. func TestServer_Request_Post_Body_ImmediateEOF(t *testing.T) {
  653. testBodyContents(t, -1, "", func(st *serverTester) {
  654. st.writeHeaders(HeadersFrameParam{
  655. StreamID: 1, // clients send odd numbers
  656. BlockFragment: st.encodeHeader(":method", "POST"),
  657. EndStream: false, // to say DATA frames are coming
  658. EndHeaders: true,
  659. })
  660. st.writeData(1, true, nil) // just kidding. empty body.
  661. })
  662. }
  663. func TestServer_Request_Post_Body_OneData(t *testing.T) {
  664. const content = "Some content"
  665. testBodyContents(t, -1, content, func(st *serverTester) {
  666. st.writeHeaders(HeadersFrameParam{
  667. StreamID: 1, // clients send odd numbers
  668. BlockFragment: st.encodeHeader(":method", "POST"),
  669. EndStream: false, // to say DATA frames are coming
  670. EndHeaders: true,
  671. })
  672. st.writeData(1, true, []byte(content))
  673. })
  674. }
  675. func TestServer_Request_Post_Body_TwoData(t *testing.T) {
  676. const content = "Some content"
  677. testBodyContents(t, -1, content, func(st *serverTester) {
  678. st.writeHeaders(HeadersFrameParam{
  679. StreamID: 1, // clients send odd numbers
  680. BlockFragment: st.encodeHeader(":method", "POST"),
  681. EndStream: false, // to say DATA frames are coming
  682. EndHeaders: true,
  683. })
  684. st.writeData(1, false, []byte(content[:5]))
  685. st.writeData(1, true, []byte(content[5:]))
  686. })
  687. }
  688. func TestServer_Request_Post_Body_ContentLength_Correct(t *testing.T) {
  689. const content = "Some content"
  690. testBodyContents(t, int64(len(content)), content, func(st *serverTester) {
  691. st.writeHeaders(HeadersFrameParam{
  692. StreamID: 1, // clients send odd numbers
  693. BlockFragment: st.encodeHeader(
  694. ":method", "POST",
  695. "content-length", strconv.Itoa(len(content)),
  696. ),
  697. EndStream: false, // to say DATA frames are coming
  698. EndHeaders: true,
  699. })
  700. st.writeData(1, true, []byte(content))
  701. })
  702. }
  703. func TestServer_Request_Post_Body_ContentLength_TooLarge(t *testing.T) {
  704. testBodyContentsFail(t, 3, "request declared a Content-Length of 3 but only wrote 2 bytes",
  705. func(st *serverTester) {
  706. st.writeHeaders(HeadersFrameParam{
  707. StreamID: 1, // clients send odd numbers
  708. BlockFragment: st.encodeHeader(
  709. ":method", "POST",
  710. "content-length", "3",
  711. ),
  712. EndStream: false, // to say DATA frames are coming
  713. EndHeaders: true,
  714. })
  715. st.writeData(1, true, []byte("12"))
  716. })
  717. }
  718. func TestServer_Request_Post_Body_ContentLength_TooSmall(t *testing.T) {
  719. testBodyContentsFail(t, 4, "sender tried to send more than declared Content-Length of 4 bytes",
  720. func(st *serverTester) {
  721. st.writeHeaders(HeadersFrameParam{
  722. StreamID: 1, // clients send odd numbers
  723. BlockFragment: st.encodeHeader(
  724. ":method", "POST",
  725. "content-length", "4",
  726. ),
  727. EndStream: false, // to say DATA frames are coming
  728. EndHeaders: true,
  729. })
  730. st.writeData(1, true, []byte("12345"))
  731. })
  732. }
  733. func testBodyContents(t *testing.T, wantContentLength int64, wantBody string, write func(st *serverTester)) {
  734. testServerRequest(t, write, func(r *http.Request) {
  735. if r.Method != "POST" {
  736. t.Errorf("Method = %q; want POST", r.Method)
  737. }
  738. if r.ContentLength != wantContentLength {
  739. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  740. }
  741. all, err := ioutil.ReadAll(r.Body)
  742. if err != nil {
  743. t.Fatal(err)
  744. }
  745. if string(all) != wantBody {
  746. t.Errorf("Read = %q; want %q", all, wantBody)
  747. }
  748. if err := r.Body.Close(); err != nil {
  749. t.Fatalf("Close: %v", err)
  750. }
  751. })
  752. }
  753. func testBodyContentsFail(t *testing.T, wantContentLength int64, wantReadError string, write func(st *serverTester)) {
  754. testServerRequest(t, write, func(r *http.Request) {
  755. if r.Method != "POST" {
  756. t.Errorf("Method = %q; want POST", r.Method)
  757. }
  758. if r.ContentLength != wantContentLength {
  759. t.Errorf("ContentLength = %v; want %d", r.ContentLength, wantContentLength)
  760. }
  761. all, err := ioutil.ReadAll(r.Body)
  762. if err == nil {
  763. t.Fatalf("expected an error (%q) reading from the body. Successfully read %q instead.",
  764. wantReadError, all)
  765. }
  766. if !strings.Contains(err.Error(), wantReadError) {
  767. t.Fatalf("Body.Read = %v; want substring %q", err, wantReadError)
  768. }
  769. if err := r.Body.Close(); err != nil {
  770. t.Fatalf("Close: %v", err)
  771. }
  772. })
  773. }
  774. // Using a Host header, instead of :authority
  775. func TestServer_Request_Get_Host(t *testing.T) {
  776. const host = "example.com"
  777. testServerRequest(t, func(st *serverTester) {
  778. st.writeHeaders(HeadersFrameParam{
  779. StreamID: 1, // clients send odd numbers
  780. BlockFragment: st.encodeHeader(":authority", "", "host", host),
  781. EndStream: true,
  782. EndHeaders: true,
  783. })
  784. }, func(r *http.Request) {
  785. if r.Host != host {
  786. t.Errorf("Host = %q; want %q", r.Host, host)
  787. }
  788. })
  789. }
  790. // Using an :authority pseudo-header, instead of Host
  791. func TestServer_Request_Get_Authority(t *testing.T) {
  792. const host = "example.com"
  793. testServerRequest(t, func(st *serverTester) {
  794. st.writeHeaders(HeadersFrameParam{
  795. StreamID: 1, // clients send odd numbers
  796. BlockFragment: st.encodeHeader(":authority", host),
  797. EndStream: true,
  798. EndHeaders: true,
  799. })
  800. }, func(r *http.Request) {
  801. if r.Host != host {
  802. t.Errorf("Host = %q; want %q", r.Host, host)
  803. }
  804. })
  805. }
  806. func TestServer_Request_WithContinuation(t *testing.T) {
  807. wantHeader := http.Header{
  808. "Foo-One": []string{"value-one"},
  809. "Foo-Two": []string{"value-two"},
  810. "Foo-Three": []string{"value-three"},
  811. }
  812. testServerRequest(t, func(st *serverTester) {
  813. fullHeaders := st.encodeHeader(
  814. "foo-one", "value-one",
  815. "foo-two", "value-two",
  816. "foo-three", "value-three",
  817. )
  818. remain := fullHeaders
  819. chunks := 0
  820. for len(remain) > 0 {
  821. const maxChunkSize = 5
  822. chunk := remain
  823. if len(chunk) > maxChunkSize {
  824. chunk = chunk[:maxChunkSize]
  825. }
  826. remain = remain[len(chunk):]
  827. if chunks == 0 {
  828. st.writeHeaders(HeadersFrameParam{
  829. StreamID: 1, // clients send odd numbers
  830. BlockFragment: chunk,
  831. EndStream: true, // no DATA frames
  832. EndHeaders: false, // we'll have continuation frames
  833. })
  834. } else {
  835. err := st.fr.WriteContinuation(1, len(remain) == 0, chunk)
  836. if err != nil {
  837. t.Fatal(err)
  838. }
  839. }
  840. chunks++
  841. }
  842. if chunks < 2 {
  843. t.Fatal("too few chunks")
  844. }
  845. }, func(r *http.Request) {
  846. if !reflect.DeepEqual(r.Header, wantHeader) {
  847. t.Errorf("Header = %#v; want %#v", r.Header, wantHeader)
  848. }
  849. })
  850. }
  851. // Concatenated cookie headers. ("8.1.2.5 Compressing the Cookie Header Field")
  852. func TestServer_Request_CookieConcat(t *testing.T) {
  853. const host = "example.com"
  854. testServerRequest(t, func(st *serverTester) {
  855. st.bodylessReq1(
  856. ":authority", host,
  857. "cookie", "a=b",
  858. "cookie", "c=d",
  859. "cookie", "e=f",
  860. )
  861. }, func(r *http.Request) {
  862. const want = "a=b; c=d; e=f"
  863. if got := r.Header.Get("Cookie"); got != want {
  864. t.Errorf("Cookie = %q; want %q", got, want)
  865. }
  866. })
  867. }
  868. func TestServer_Request_Reject_CapitalHeader(t *testing.T) {
  869. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("UPPER", "v") })
  870. }
  871. func TestServer_Request_Reject_HeaderFieldNameColon(t *testing.T) {
  872. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has:colon", "v") })
  873. }
  874. func TestServer_Request_Reject_HeaderFieldNameNULL(t *testing.T) {
  875. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("has\x00null", "v") })
  876. }
  877. func TestServer_Request_Reject_HeaderFieldNameEmpty(t *testing.T) {
  878. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("", "v") })
  879. }
  880. func TestServer_Request_Reject_HeaderFieldValueNewline(t *testing.T) {
  881. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\nnewline") })
  882. }
  883. func TestServer_Request_Reject_HeaderFieldValueCR(t *testing.T) {
  884. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\rcarriage") })
  885. }
  886. func TestServer_Request_Reject_HeaderFieldValueDEL(t *testing.T) {
  887. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1("foo", "has\x7fdel") })
  888. }
  889. func TestServer_Request_Reject_Pseudo_Missing_method(t *testing.T) {
  890. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":method", "") })
  891. }
  892. func TestServer_Request_Reject_Pseudo_ExactlyOne(t *testing.T) {
  893. // 8.1.2.3 Request Pseudo-Header Fields
  894. // "All HTTP/2 requests MUST include exactly one valid value" ...
  895. testRejectRequest(t, func(st *serverTester) {
  896. st.addLogFilter("duplicate pseudo-header")
  897. st.bodylessReq1(":method", "GET", ":method", "POST")
  898. })
  899. }
  900. func TestServer_Request_Reject_Pseudo_AfterRegular(t *testing.T) {
  901. // 8.1.2.3 Request Pseudo-Header Fields
  902. // "All pseudo-header fields MUST appear in the header block
  903. // before regular header fields. Any request or response that
  904. // contains a pseudo-header field that appears in a header
  905. // block after a regular header field MUST be treated as
  906. // malformed (Section 8.1.2.6)."
  907. testRejectRequest(t, func(st *serverTester) {
  908. st.addLogFilter("pseudo-header after regular header")
  909. var buf bytes.Buffer
  910. enc := hpack.NewEncoder(&buf)
  911. enc.WriteField(hpack.HeaderField{Name: ":method", Value: "GET"})
  912. enc.WriteField(hpack.HeaderField{Name: "regular", Value: "foobar"})
  913. enc.WriteField(hpack.HeaderField{Name: ":path", Value: "/"})
  914. enc.WriteField(hpack.HeaderField{Name: ":scheme", Value: "https"})
  915. st.writeHeaders(HeadersFrameParam{
  916. StreamID: 1, // clients send odd numbers
  917. BlockFragment: buf.Bytes(),
  918. EndStream: true,
  919. EndHeaders: true,
  920. })
  921. })
  922. }
  923. func TestServer_Request_Reject_Pseudo_Missing_path(t *testing.T) {
  924. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":path", "") })
  925. }
  926. func TestServer_Request_Reject_Pseudo_Missing_scheme(t *testing.T) {
  927. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "") })
  928. }
  929. func TestServer_Request_Reject_Pseudo_scheme_invalid(t *testing.T) {
  930. testRejectRequest(t, func(st *serverTester) { st.bodylessReq1(":scheme", "bogus") })
  931. }
  932. func TestServer_Request_Reject_Pseudo_Unknown(t *testing.T) {
  933. testRejectRequest(t, func(st *serverTester) {
  934. st.addLogFilter(`invalid pseudo-header ":unknown_thing"`)
  935. st.bodylessReq1(":unknown_thing", "")
  936. })
  937. }
  938. func testRejectRequest(t *testing.T, send func(*serverTester)) {
  939. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  940. t.Error("server request made it to handler; should've been rejected")
  941. })
  942. defer st.Close()
  943. st.greet()
  944. send(st)
  945. st.wantRSTStream(1, ErrCodeProtocol)
  946. }
  947. func testRejectRequestWithProtocolError(t *testing.T, send func(*serverTester)) {
  948. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  949. t.Error("server request made it to handler; should've been rejected")
  950. }, optQuiet)
  951. defer st.Close()
  952. st.greet()
  953. send(st)
  954. gf := st.wantGoAway()
  955. if gf.ErrCode != ErrCodeProtocol {
  956. t.Errorf("err code = %v; want %v", gf.ErrCode, ErrCodeProtocol)
  957. }
  958. }
  959. // Section 5.1, on idle connections: "Receiving any frame other than
  960. // HEADERS or PRIORITY on a stream in this state MUST be treated as a
  961. // connection error (Section 5.4.1) of type PROTOCOL_ERROR."
  962. func TestRejectFrameOnIdle_WindowUpdate(t *testing.T) {
  963. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  964. st.fr.WriteWindowUpdate(123, 456)
  965. })
  966. }
  967. func TestRejectFrameOnIdle_Data(t *testing.T) {
  968. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  969. st.fr.WriteData(123, true, nil)
  970. })
  971. }
  972. func TestRejectFrameOnIdle_RSTStream(t *testing.T) {
  973. testRejectRequestWithProtocolError(t, func(st *serverTester) {
  974. st.fr.WriteRSTStream(123, ErrCodeCancel)
  975. })
  976. }
  977. func TestServer_Request_Connect(t *testing.T) {
  978. testServerRequest(t, func(st *serverTester) {
  979. st.writeHeaders(HeadersFrameParam{
  980. StreamID: 1,
  981. BlockFragment: st.encodeHeaderRaw(
  982. ":method", "CONNECT",
  983. ":authority", "example.com:123",
  984. ),
  985. EndStream: true,
  986. EndHeaders: true,
  987. })
  988. }, func(r *http.Request) {
  989. if g, w := r.Method, "CONNECT"; g != w {
  990. t.Errorf("Method = %q; want %q", g, w)
  991. }
  992. if g, w := r.RequestURI, "example.com:123"; g != w {
  993. t.Errorf("RequestURI = %q; want %q", g, w)
  994. }
  995. if g, w := r.URL.Host, "example.com:123"; g != w {
  996. t.Errorf("URL.Host = %q; want %q", g, w)
  997. }
  998. })
  999. }
  1000. func TestServer_Request_Connect_InvalidPath(t *testing.T) {
  1001. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1002. st.writeHeaders(HeadersFrameParam{
  1003. StreamID: 1,
  1004. BlockFragment: st.encodeHeaderRaw(
  1005. ":method", "CONNECT",
  1006. ":authority", "example.com:123",
  1007. ":path", "/bogus",
  1008. ),
  1009. EndStream: true,
  1010. EndHeaders: true,
  1011. })
  1012. })
  1013. }
  1014. func TestServer_Request_Connect_InvalidScheme(t *testing.T) {
  1015. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1016. st.writeHeaders(HeadersFrameParam{
  1017. StreamID: 1,
  1018. BlockFragment: st.encodeHeaderRaw(
  1019. ":method", "CONNECT",
  1020. ":authority", "example.com:123",
  1021. ":scheme", "https",
  1022. ),
  1023. EndStream: true,
  1024. EndHeaders: true,
  1025. })
  1026. })
  1027. }
  1028. func TestServer_Ping(t *testing.T) {
  1029. st := newServerTester(t, nil)
  1030. defer st.Close()
  1031. st.greet()
  1032. // Server should ignore this one, since it has ACK set.
  1033. ackPingData := [8]byte{1, 2, 4, 8, 16, 32, 64, 128}
  1034. if err := st.fr.WritePing(true, ackPingData); err != nil {
  1035. t.Fatal(err)
  1036. }
  1037. // But the server should reply to this one, since ACK is false.
  1038. pingData := [8]byte{1, 2, 3, 4, 5, 6, 7, 8}
  1039. if err := st.fr.WritePing(false, pingData); err != nil {
  1040. t.Fatal(err)
  1041. }
  1042. pf := st.wantPing()
  1043. if !pf.Flags.Has(FlagPingAck) {
  1044. t.Error("response ping doesn't have ACK set")
  1045. }
  1046. if pf.Data != pingData {
  1047. t.Errorf("response ping has data %q; want %q", pf.Data, pingData)
  1048. }
  1049. }
  1050. func TestServer_RejectsLargeFrames(t *testing.T) {
  1051. if runtime.GOOS == "windows" {
  1052. t.Skip("see golang.org/issue/13434")
  1053. }
  1054. st := newServerTester(t, nil)
  1055. defer st.Close()
  1056. st.greet()
  1057. // Write too large of a frame (too large by one byte)
  1058. // We ignore the return value because it's expected that the server
  1059. // will only read the first 9 bytes (the headre) and then disconnect.
  1060. st.fr.WriteRawFrame(0xff, 0, 0, make([]byte, defaultMaxReadFrameSize+1))
  1061. gf := st.wantGoAway()
  1062. if gf.ErrCode != ErrCodeFrameSize {
  1063. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFrameSize)
  1064. }
  1065. if st.serverLogBuf.Len() != 0 {
  1066. // Previously we spun here for a bit until the GOAWAY disconnect
  1067. // timer fired, logging while we fired.
  1068. t.Errorf("unexpected server output: %.500s\n", st.serverLogBuf.Bytes())
  1069. }
  1070. }
  1071. func TestServer_Handler_Sends_WindowUpdate(t *testing.T) {
  1072. puppet := newHandlerPuppet()
  1073. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1074. puppet.act(w, r)
  1075. })
  1076. defer st.Close()
  1077. defer puppet.done()
  1078. st.greet()
  1079. st.writeHeaders(HeadersFrameParam{
  1080. StreamID: 1, // clients send odd numbers
  1081. BlockFragment: st.encodeHeader(":method", "POST"),
  1082. EndStream: false, // data coming
  1083. EndHeaders: true,
  1084. })
  1085. st.writeData(1, false, []byte("abcdef"))
  1086. puppet.do(readBodyHandler(t, "abc"))
  1087. st.wantWindowUpdate(0, 3)
  1088. st.wantWindowUpdate(1, 3)
  1089. puppet.do(readBodyHandler(t, "def"))
  1090. st.wantWindowUpdate(0, 3)
  1091. st.wantWindowUpdate(1, 3)
  1092. st.writeData(1, true, []byte("ghijkl")) // END_STREAM here
  1093. puppet.do(readBodyHandler(t, "ghi"))
  1094. puppet.do(readBodyHandler(t, "jkl"))
  1095. st.wantWindowUpdate(0, 3)
  1096. st.wantWindowUpdate(0, 3) // no more stream-level, since END_STREAM
  1097. }
  1098. // the version of the TestServer_Handler_Sends_WindowUpdate with padding.
  1099. // See golang.org/issue/16556
  1100. func TestServer_Handler_Sends_WindowUpdate_Padding(t *testing.T) {
  1101. puppet := newHandlerPuppet()
  1102. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1103. puppet.act(w, r)
  1104. })
  1105. defer st.Close()
  1106. defer puppet.done()
  1107. st.greet()
  1108. st.writeHeaders(HeadersFrameParam{
  1109. StreamID: 1,
  1110. BlockFragment: st.encodeHeader(":method", "POST"),
  1111. EndStream: false,
  1112. EndHeaders: true,
  1113. })
  1114. st.writeDataPadded(1, false, []byte("abcdef"), []byte{0, 0, 0, 0})
  1115. // Expect to immediately get our 5 bytes of padding back for
  1116. // both the connection and stream (4 bytes of padding + 1 byte of length)
  1117. st.wantWindowUpdate(0, 5)
  1118. st.wantWindowUpdate(1, 5)
  1119. puppet.do(readBodyHandler(t, "abc"))
  1120. st.wantWindowUpdate(0, 3)
  1121. st.wantWindowUpdate(1, 3)
  1122. puppet.do(readBodyHandler(t, "def"))
  1123. st.wantWindowUpdate(0, 3)
  1124. st.wantWindowUpdate(1, 3)
  1125. }
  1126. func TestServer_Send_GoAway_After_Bogus_WindowUpdate(t *testing.T) {
  1127. st := newServerTester(t, nil)
  1128. defer st.Close()
  1129. st.greet()
  1130. if err := st.fr.WriteWindowUpdate(0, 1<<31-1); err != nil {
  1131. t.Fatal(err)
  1132. }
  1133. gf := st.wantGoAway()
  1134. if gf.ErrCode != ErrCodeFlowControl {
  1135. t.Errorf("GOAWAY err = %v; want %v", gf.ErrCode, ErrCodeFlowControl)
  1136. }
  1137. if gf.LastStreamID != 0 {
  1138. t.Errorf("GOAWAY last stream ID = %v; want %v", gf.LastStreamID, 0)
  1139. }
  1140. }
  1141. func TestServer_Send_RstStream_After_Bogus_WindowUpdate(t *testing.T) {
  1142. inHandler := make(chan bool)
  1143. blockHandler := make(chan bool)
  1144. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1145. inHandler <- true
  1146. <-blockHandler
  1147. })
  1148. defer st.Close()
  1149. defer close(blockHandler)
  1150. st.greet()
  1151. st.writeHeaders(HeadersFrameParam{
  1152. StreamID: 1,
  1153. BlockFragment: st.encodeHeader(":method", "POST"),
  1154. EndStream: false, // keep it open
  1155. EndHeaders: true,
  1156. })
  1157. <-inHandler
  1158. // Send a bogus window update:
  1159. if err := st.fr.WriteWindowUpdate(1, 1<<31-1); err != nil {
  1160. t.Fatal(err)
  1161. }
  1162. st.wantRSTStream(1, ErrCodeFlowControl)
  1163. }
  1164. // testServerPostUnblock sends a hanging POST with unsent data to handler,
  1165. // then runs fn once in the handler, and verifies that the error returned from
  1166. // handler is acceptable. It fails if takes over 5 seconds for handler to exit.
  1167. func testServerPostUnblock(t *testing.T,
  1168. handler func(http.ResponseWriter, *http.Request) error,
  1169. fn func(*serverTester),
  1170. checkErr func(error),
  1171. otherHeaders ...string) {
  1172. inHandler := make(chan bool)
  1173. errc := make(chan error, 1)
  1174. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1175. inHandler <- true
  1176. errc <- handler(w, r)
  1177. })
  1178. defer st.Close()
  1179. st.greet()
  1180. st.writeHeaders(HeadersFrameParam{
  1181. StreamID: 1,
  1182. BlockFragment: st.encodeHeader(append([]string{":method", "POST"}, otherHeaders...)...),
  1183. EndStream: false, // keep it open
  1184. EndHeaders: true,
  1185. })
  1186. <-inHandler
  1187. fn(st)
  1188. select {
  1189. case err := <-errc:
  1190. if checkErr != nil {
  1191. checkErr(err)
  1192. }
  1193. case <-time.After(5 * time.Second):
  1194. t.Fatal("timeout waiting for Handler to return")
  1195. }
  1196. }
  1197. func TestServer_RSTStream_Unblocks_Read(t *testing.T) {
  1198. testServerPostUnblock(t,
  1199. func(w http.ResponseWriter, r *http.Request) (err error) {
  1200. _, err = r.Body.Read(make([]byte, 1))
  1201. return
  1202. },
  1203. func(st *serverTester) {
  1204. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1205. t.Fatal(err)
  1206. }
  1207. },
  1208. func(err error) {
  1209. want := StreamError{StreamID: 0x1, Code: 0x8}
  1210. if !reflect.DeepEqual(err, want) {
  1211. t.Errorf("Read error = %v; want %v", err, want)
  1212. }
  1213. },
  1214. )
  1215. }
  1216. func TestServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1217. // Run this test a bunch, because it doesn't always
  1218. // deadlock. But with a bunch, it did.
  1219. n := 50
  1220. if testing.Short() {
  1221. n = 5
  1222. }
  1223. for i := 0; i < n; i++ {
  1224. testServer_RSTStream_Unblocks_Header_Write(t)
  1225. }
  1226. }
  1227. func testServer_RSTStream_Unblocks_Header_Write(t *testing.T) {
  1228. inHandler := make(chan bool, 1)
  1229. unblockHandler := make(chan bool, 1)
  1230. headerWritten := make(chan bool, 1)
  1231. wroteRST := make(chan bool, 1)
  1232. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1233. inHandler <- true
  1234. <-wroteRST
  1235. w.Header().Set("foo", "bar")
  1236. w.WriteHeader(200)
  1237. w.(http.Flusher).Flush()
  1238. headerWritten <- true
  1239. <-unblockHandler
  1240. })
  1241. defer st.Close()
  1242. st.greet()
  1243. st.writeHeaders(HeadersFrameParam{
  1244. StreamID: 1,
  1245. BlockFragment: st.encodeHeader(":method", "POST"),
  1246. EndStream: false, // keep it open
  1247. EndHeaders: true,
  1248. })
  1249. <-inHandler
  1250. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1251. t.Fatal(err)
  1252. }
  1253. wroteRST <- true
  1254. st.awaitIdle()
  1255. select {
  1256. case <-headerWritten:
  1257. case <-time.After(2 * time.Second):
  1258. t.Error("timeout waiting for header write")
  1259. }
  1260. unblockHandler <- true
  1261. }
  1262. func TestServer_DeadConn_Unblocks_Read(t *testing.T) {
  1263. testServerPostUnblock(t,
  1264. func(w http.ResponseWriter, r *http.Request) (err error) {
  1265. _, err = r.Body.Read(make([]byte, 1))
  1266. return
  1267. },
  1268. func(st *serverTester) { st.cc.Close() },
  1269. func(err error) {
  1270. if err == nil {
  1271. t.Error("unexpected nil error from Request.Body.Read")
  1272. }
  1273. },
  1274. )
  1275. }
  1276. var blockUntilClosed = func(w http.ResponseWriter, r *http.Request) error {
  1277. <-w.(http.CloseNotifier).CloseNotify()
  1278. return nil
  1279. }
  1280. func TestServer_CloseNotify_After_RSTStream(t *testing.T) {
  1281. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1282. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1283. t.Fatal(err)
  1284. }
  1285. }, nil)
  1286. }
  1287. func TestServer_CloseNotify_After_ConnClose(t *testing.T) {
  1288. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) { st.cc.Close() }, nil)
  1289. }
  1290. // that CloseNotify unblocks after a stream error due to the client's
  1291. // problem that's unrelated to them explicitly canceling it (which is
  1292. // TestServer_CloseNotify_After_RSTStream above)
  1293. func TestServer_CloseNotify_After_StreamError(t *testing.T) {
  1294. testServerPostUnblock(t, blockUntilClosed, func(st *serverTester) {
  1295. // data longer than declared Content-Length => stream error
  1296. st.writeData(1, true, []byte("1234"))
  1297. }, nil, "content-length", "3")
  1298. }
  1299. func TestServer_StateTransitions(t *testing.T) {
  1300. var st *serverTester
  1301. inHandler := make(chan bool)
  1302. writeData := make(chan bool)
  1303. leaveHandler := make(chan bool)
  1304. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1305. inHandler <- true
  1306. if st.stream(1) == nil {
  1307. t.Errorf("nil stream 1 in handler")
  1308. }
  1309. if got, want := st.streamState(1), stateOpen; got != want {
  1310. t.Errorf("in handler, state is %v; want %v", got, want)
  1311. }
  1312. writeData <- true
  1313. if n, err := r.Body.Read(make([]byte, 1)); n != 0 || err != io.EOF {
  1314. t.Errorf("body read = %d, %v; want 0, EOF", n, err)
  1315. }
  1316. if got, want := st.streamState(1), stateHalfClosedRemote; got != want {
  1317. t.Errorf("in handler, state is %v; want %v", got, want)
  1318. }
  1319. <-leaveHandler
  1320. })
  1321. st.greet()
  1322. if st.stream(1) != nil {
  1323. t.Fatal("stream 1 should be empty")
  1324. }
  1325. if got := st.streamState(1); got != stateIdle {
  1326. t.Fatalf("stream 1 should be idle; got %v", got)
  1327. }
  1328. st.writeHeaders(HeadersFrameParam{
  1329. StreamID: 1,
  1330. BlockFragment: st.encodeHeader(":method", "POST"),
  1331. EndStream: false, // keep it open
  1332. EndHeaders: true,
  1333. })
  1334. <-inHandler
  1335. <-writeData
  1336. st.writeData(1, true, nil)
  1337. leaveHandler <- true
  1338. hf := st.wantHeaders()
  1339. if !hf.StreamEnded() {
  1340. t.Fatal("expected END_STREAM flag")
  1341. }
  1342. if got, want := st.streamState(1), stateClosed; got != want {
  1343. t.Errorf("at end, state is %v; want %v", got, want)
  1344. }
  1345. if st.stream(1) != nil {
  1346. t.Fatal("at end, stream 1 should be gone")
  1347. }
  1348. }
  1349. // test HEADERS w/o EndHeaders + another HEADERS (should get rejected)
  1350. func TestServer_Rejects_HeadersNoEnd_Then_Headers(t *testing.T) {
  1351. testServerRejectsConn(t, func(st *serverTester) {
  1352. st.writeHeaders(HeadersFrameParam{
  1353. StreamID: 1,
  1354. BlockFragment: st.encodeHeader(),
  1355. EndStream: true,
  1356. EndHeaders: false,
  1357. })
  1358. st.writeHeaders(HeadersFrameParam{ // Not a continuation.
  1359. StreamID: 3, // different stream.
  1360. BlockFragment: st.encodeHeader(),
  1361. EndStream: true,
  1362. EndHeaders: true,
  1363. })
  1364. })
  1365. }
  1366. // test HEADERS w/o EndHeaders + PING (should get rejected)
  1367. func TestServer_Rejects_HeadersNoEnd_Then_Ping(t *testing.T) {
  1368. testServerRejectsConn(t, func(st *serverTester) {
  1369. st.writeHeaders(HeadersFrameParam{
  1370. StreamID: 1,
  1371. BlockFragment: st.encodeHeader(),
  1372. EndStream: true,
  1373. EndHeaders: false,
  1374. })
  1375. if err := st.fr.WritePing(false, [8]byte{}); err != nil {
  1376. t.Fatal(err)
  1377. }
  1378. })
  1379. }
  1380. // test HEADERS w/ EndHeaders + a continuation HEADERS (should get rejected)
  1381. func TestServer_Rejects_HeadersEnd_Then_Continuation(t *testing.T) {
  1382. testServerRejectsConn(t, func(st *serverTester) {
  1383. st.writeHeaders(HeadersFrameParam{
  1384. StreamID: 1,
  1385. BlockFragment: st.encodeHeader(),
  1386. EndStream: true,
  1387. EndHeaders: true,
  1388. })
  1389. st.wantHeaders()
  1390. if err := st.fr.WriteContinuation(1, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1391. t.Fatal(err)
  1392. }
  1393. })
  1394. }
  1395. // test HEADERS w/o EndHeaders + a continuation HEADERS on wrong stream ID
  1396. func TestServer_Rejects_HeadersNoEnd_Then_ContinuationWrongStream(t *testing.T) {
  1397. testServerRejectsConn(t, func(st *serverTester) {
  1398. st.writeHeaders(HeadersFrameParam{
  1399. StreamID: 1,
  1400. BlockFragment: st.encodeHeader(),
  1401. EndStream: true,
  1402. EndHeaders: false,
  1403. })
  1404. if err := st.fr.WriteContinuation(3, true, encodeHeaderNoImplicit(t, "foo", "bar")); err != nil {
  1405. t.Fatal(err)
  1406. }
  1407. })
  1408. }
  1409. // No HEADERS on stream 0.
  1410. func TestServer_Rejects_Headers0(t *testing.T) {
  1411. testServerRejectsConn(t, func(st *serverTester) {
  1412. st.fr.AllowIllegalWrites = true
  1413. st.writeHeaders(HeadersFrameParam{
  1414. StreamID: 0,
  1415. BlockFragment: st.encodeHeader(),
  1416. EndStream: true,
  1417. EndHeaders: true,
  1418. })
  1419. })
  1420. }
  1421. // No CONTINUATION on stream 0.
  1422. func TestServer_Rejects_Continuation0(t *testing.T) {
  1423. testServerRejectsConn(t, func(st *serverTester) {
  1424. st.fr.AllowIllegalWrites = true
  1425. if err := st.fr.WriteContinuation(0, true, st.encodeHeader()); err != nil {
  1426. t.Fatal(err)
  1427. }
  1428. })
  1429. }
  1430. // No PRIORITY on stream 0.
  1431. func TestServer_Rejects_Priority0(t *testing.T) {
  1432. testServerRejectsConn(t, func(st *serverTester) {
  1433. st.fr.AllowIllegalWrites = true
  1434. st.writePriority(0, PriorityParam{StreamDep: 1})
  1435. })
  1436. }
  1437. // No HEADERS frame with a self-dependence.
  1438. func TestServer_Rejects_HeadersSelfDependence(t *testing.T) {
  1439. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1440. st.fr.AllowIllegalWrites = true
  1441. st.writeHeaders(HeadersFrameParam{
  1442. StreamID: 1,
  1443. BlockFragment: st.encodeHeader(),
  1444. EndStream: true,
  1445. EndHeaders: true,
  1446. Priority: PriorityParam{StreamDep: 1},
  1447. })
  1448. })
  1449. }
  1450. // No PRIORTY frame with a self-dependence.
  1451. func TestServer_Rejects_PrioritySelfDependence(t *testing.T) {
  1452. testServerRejectsStream(t, ErrCodeProtocol, func(st *serverTester) {
  1453. st.fr.AllowIllegalWrites = true
  1454. st.writePriority(1, PriorityParam{StreamDep: 1})
  1455. })
  1456. }
  1457. func TestServer_Rejects_PushPromise(t *testing.T) {
  1458. testServerRejectsConn(t, func(st *serverTester) {
  1459. pp := PushPromiseParam{
  1460. StreamID: 1,
  1461. PromiseID: 3,
  1462. }
  1463. if err := st.fr.WritePushPromise(pp); err != nil {
  1464. t.Fatal(err)
  1465. }
  1466. })
  1467. }
  1468. // testServerRejectsConn tests that the server hangs up with a GOAWAY
  1469. // frame and a server close after the client does something
  1470. // deserving a CONNECTION_ERROR.
  1471. func testServerRejectsConn(t *testing.T, writeReq func(*serverTester)) {
  1472. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1473. st.addLogFilter("connection error: PROTOCOL_ERROR")
  1474. defer st.Close()
  1475. st.greet()
  1476. writeReq(st)
  1477. st.wantGoAway()
  1478. errc := make(chan error, 1)
  1479. go func() {
  1480. fr, err := st.fr.ReadFrame()
  1481. if err == nil {
  1482. err = fmt.Errorf("got frame of type %T", fr)
  1483. }
  1484. errc <- err
  1485. }()
  1486. select {
  1487. case err := <-errc:
  1488. if err != io.EOF {
  1489. t.Errorf("ReadFrame = %v; want io.EOF", err)
  1490. }
  1491. case <-time.After(2 * time.Second):
  1492. t.Error("timeout waiting for disconnect")
  1493. }
  1494. }
  1495. // testServerRejectsStream tests that the server sends a RST_STREAM with the provided
  1496. // error code after a client sends a bogus request.
  1497. func testServerRejectsStream(t *testing.T, code ErrCode, writeReq func(*serverTester)) {
  1498. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  1499. defer st.Close()
  1500. st.greet()
  1501. writeReq(st)
  1502. st.wantRSTStream(1, code)
  1503. }
  1504. // testServerRequest sets up an idle HTTP/2 connection and lets you
  1505. // write a single request with writeReq, and then verify that the
  1506. // *http.Request is built correctly in checkReq.
  1507. func testServerRequest(t *testing.T, writeReq func(*serverTester), checkReq func(*http.Request)) {
  1508. gotReq := make(chan bool, 1)
  1509. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  1510. if r.Body == nil {
  1511. t.Fatal("nil Body")
  1512. }
  1513. checkReq(r)
  1514. gotReq <- true
  1515. })
  1516. defer st.Close()
  1517. st.greet()
  1518. writeReq(st)
  1519. select {
  1520. case <-gotReq:
  1521. case <-time.After(2 * time.Second):
  1522. t.Error("timeout waiting for request")
  1523. }
  1524. }
  1525. func getSlash(st *serverTester) { st.bodylessReq1() }
  1526. func TestServer_Response_NoData(t *testing.T) {
  1527. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1528. // Nothing.
  1529. return nil
  1530. }, func(st *serverTester) {
  1531. getSlash(st)
  1532. hf := st.wantHeaders()
  1533. if !hf.StreamEnded() {
  1534. t.Fatal("want END_STREAM flag")
  1535. }
  1536. if !hf.HeadersEnded() {
  1537. t.Fatal("want END_HEADERS flag")
  1538. }
  1539. })
  1540. }
  1541. func TestServer_Response_NoData_Header_FooBar(t *testing.T) {
  1542. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1543. w.Header().Set("Foo-Bar", "some-value")
  1544. return nil
  1545. }, func(st *serverTester) {
  1546. getSlash(st)
  1547. hf := st.wantHeaders()
  1548. if !hf.StreamEnded() {
  1549. t.Fatal("want END_STREAM flag")
  1550. }
  1551. if !hf.HeadersEnded() {
  1552. t.Fatal("want END_HEADERS flag")
  1553. }
  1554. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1555. wanth := [][2]string{
  1556. {":status", "200"},
  1557. {"foo-bar", "some-value"},
  1558. {"content-length", "0"},
  1559. }
  1560. if !reflect.DeepEqual(goth, wanth) {
  1561. t.Errorf("Got headers %v; want %v", goth, wanth)
  1562. }
  1563. })
  1564. }
  1565. func TestServer_Response_Data_Sniff_DoesntOverride(t *testing.T) {
  1566. const msg = "<html>this is HTML."
  1567. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1568. w.Header().Set("Content-Type", "foo/bar")
  1569. io.WriteString(w, msg)
  1570. return nil
  1571. }, func(st *serverTester) {
  1572. getSlash(st)
  1573. hf := st.wantHeaders()
  1574. if hf.StreamEnded() {
  1575. t.Fatal("don't want END_STREAM, expecting data")
  1576. }
  1577. if !hf.HeadersEnded() {
  1578. t.Fatal("want END_HEADERS flag")
  1579. }
  1580. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1581. wanth := [][2]string{
  1582. {":status", "200"},
  1583. {"content-type", "foo/bar"},
  1584. {"content-length", strconv.Itoa(len(msg))},
  1585. }
  1586. if !reflect.DeepEqual(goth, wanth) {
  1587. t.Errorf("Got headers %v; want %v", goth, wanth)
  1588. }
  1589. df := st.wantData()
  1590. if !df.StreamEnded() {
  1591. t.Error("expected DATA to have END_STREAM flag")
  1592. }
  1593. if got := string(df.Data()); got != msg {
  1594. t.Errorf("got DATA %q; want %q", got, msg)
  1595. }
  1596. })
  1597. }
  1598. func TestServer_Response_TransferEncoding_chunked(t *testing.T) {
  1599. const msg = "hi"
  1600. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1601. w.Header().Set("Transfer-Encoding", "chunked") // should be stripped
  1602. io.WriteString(w, msg)
  1603. return nil
  1604. }, func(st *serverTester) {
  1605. getSlash(st)
  1606. hf := st.wantHeaders()
  1607. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1608. wanth := [][2]string{
  1609. {":status", "200"},
  1610. {"content-type", "text/plain; charset=utf-8"},
  1611. {"content-length", strconv.Itoa(len(msg))},
  1612. }
  1613. if !reflect.DeepEqual(goth, wanth) {
  1614. t.Errorf("Got headers %v; want %v", goth, wanth)
  1615. }
  1616. })
  1617. }
  1618. // Header accessed only after the initial write.
  1619. func TestServer_Response_Data_IgnoreHeaderAfterWrite_After(t *testing.T) {
  1620. const msg = "<html>this is HTML."
  1621. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1622. io.WriteString(w, msg)
  1623. w.Header().Set("foo", "should be ignored")
  1624. return nil
  1625. }, func(st *serverTester) {
  1626. getSlash(st)
  1627. hf := st.wantHeaders()
  1628. if hf.StreamEnded() {
  1629. t.Fatal("unexpected END_STREAM")
  1630. }
  1631. if !hf.HeadersEnded() {
  1632. t.Fatal("want END_HEADERS flag")
  1633. }
  1634. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1635. wanth := [][2]string{
  1636. {":status", "200"},
  1637. {"content-type", "text/html; charset=utf-8"},
  1638. {"content-length", strconv.Itoa(len(msg))},
  1639. }
  1640. if !reflect.DeepEqual(goth, wanth) {
  1641. t.Errorf("Got headers %v; want %v", goth, wanth)
  1642. }
  1643. })
  1644. }
  1645. // Header accessed before the initial write and later mutated.
  1646. func TestServer_Response_Data_IgnoreHeaderAfterWrite_Overwrite(t *testing.T) {
  1647. const msg = "<html>this is HTML."
  1648. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1649. w.Header().Set("foo", "proper value")
  1650. io.WriteString(w, msg)
  1651. w.Header().Set("foo", "should be ignored")
  1652. return nil
  1653. }, func(st *serverTester) {
  1654. getSlash(st)
  1655. hf := st.wantHeaders()
  1656. if hf.StreamEnded() {
  1657. t.Fatal("unexpected END_STREAM")
  1658. }
  1659. if !hf.HeadersEnded() {
  1660. t.Fatal("want END_HEADERS flag")
  1661. }
  1662. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1663. wanth := [][2]string{
  1664. {":status", "200"},
  1665. {"foo", "proper value"},
  1666. {"content-type", "text/html; charset=utf-8"},
  1667. {"content-length", strconv.Itoa(len(msg))},
  1668. }
  1669. if !reflect.DeepEqual(goth, wanth) {
  1670. t.Errorf("Got headers %v; want %v", goth, wanth)
  1671. }
  1672. })
  1673. }
  1674. func TestServer_Response_Data_SniffLenType(t *testing.T) {
  1675. const msg = "<html>this is HTML."
  1676. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1677. io.WriteString(w, msg)
  1678. return nil
  1679. }, func(st *serverTester) {
  1680. getSlash(st)
  1681. hf := st.wantHeaders()
  1682. if hf.StreamEnded() {
  1683. t.Fatal("don't want END_STREAM, expecting data")
  1684. }
  1685. if !hf.HeadersEnded() {
  1686. t.Fatal("want END_HEADERS flag")
  1687. }
  1688. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1689. wanth := [][2]string{
  1690. {":status", "200"},
  1691. {"content-type", "text/html; charset=utf-8"},
  1692. {"content-length", strconv.Itoa(len(msg))},
  1693. }
  1694. if !reflect.DeepEqual(goth, wanth) {
  1695. t.Errorf("Got headers %v; want %v", goth, wanth)
  1696. }
  1697. df := st.wantData()
  1698. if !df.StreamEnded() {
  1699. t.Error("expected DATA to have END_STREAM flag")
  1700. }
  1701. if got := string(df.Data()); got != msg {
  1702. t.Errorf("got DATA %q; want %q", got, msg)
  1703. }
  1704. })
  1705. }
  1706. func TestServer_Response_Header_Flush_MidWrite(t *testing.T) {
  1707. const msg = "<html>this is HTML"
  1708. const msg2 = ", and this is the next chunk"
  1709. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1710. io.WriteString(w, msg)
  1711. w.(http.Flusher).Flush()
  1712. io.WriteString(w, msg2)
  1713. return nil
  1714. }, func(st *serverTester) {
  1715. getSlash(st)
  1716. hf := st.wantHeaders()
  1717. if hf.StreamEnded() {
  1718. t.Fatal("unexpected END_STREAM flag")
  1719. }
  1720. if !hf.HeadersEnded() {
  1721. t.Fatal("want END_HEADERS flag")
  1722. }
  1723. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1724. wanth := [][2]string{
  1725. {":status", "200"},
  1726. {"content-type", "text/html; charset=utf-8"}, // sniffed
  1727. // and no content-length
  1728. }
  1729. if !reflect.DeepEqual(goth, wanth) {
  1730. t.Errorf("Got headers %v; want %v", goth, wanth)
  1731. }
  1732. {
  1733. df := st.wantData()
  1734. if df.StreamEnded() {
  1735. t.Error("unexpected END_STREAM flag")
  1736. }
  1737. if got := string(df.Data()); got != msg {
  1738. t.Errorf("got DATA %q; want %q", got, msg)
  1739. }
  1740. }
  1741. {
  1742. df := st.wantData()
  1743. if !df.StreamEnded() {
  1744. t.Error("wanted END_STREAM flag on last data chunk")
  1745. }
  1746. if got := string(df.Data()); got != msg2 {
  1747. t.Errorf("got DATA %q; want %q", got, msg2)
  1748. }
  1749. }
  1750. })
  1751. }
  1752. func TestServer_Response_LargeWrite(t *testing.T) {
  1753. const size = 1 << 20
  1754. const maxFrameSize = 16 << 10
  1755. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1756. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1757. if err != nil {
  1758. return fmt.Errorf("Write error: %v", err)
  1759. }
  1760. if n != size {
  1761. return fmt.Errorf("wrong size %d from Write", n)
  1762. }
  1763. return nil
  1764. }, func(st *serverTester) {
  1765. if err := st.fr.WriteSettings(
  1766. Setting{SettingInitialWindowSize, 0},
  1767. Setting{SettingMaxFrameSize, maxFrameSize},
  1768. ); err != nil {
  1769. t.Fatal(err)
  1770. }
  1771. st.wantSettingsAck()
  1772. getSlash(st) // make the single request
  1773. // Give the handler quota to write:
  1774. if err := st.fr.WriteWindowUpdate(1, size); err != nil {
  1775. t.Fatal(err)
  1776. }
  1777. // Give the handler quota to write to connection-level
  1778. // window as well
  1779. if err := st.fr.WriteWindowUpdate(0, size); err != nil {
  1780. t.Fatal(err)
  1781. }
  1782. hf := st.wantHeaders()
  1783. if hf.StreamEnded() {
  1784. t.Fatal("unexpected END_STREAM flag")
  1785. }
  1786. if !hf.HeadersEnded() {
  1787. t.Fatal("want END_HEADERS flag")
  1788. }
  1789. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1790. wanth := [][2]string{
  1791. {":status", "200"},
  1792. {"content-type", "text/plain; charset=utf-8"}, // sniffed
  1793. // and no content-length
  1794. }
  1795. if !reflect.DeepEqual(goth, wanth) {
  1796. t.Errorf("Got headers %v; want %v", goth, wanth)
  1797. }
  1798. var bytes, frames int
  1799. for {
  1800. df := st.wantData()
  1801. bytes += len(df.Data())
  1802. frames++
  1803. for _, b := range df.Data() {
  1804. if b != 'a' {
  1805. t.Fatal("non-'a' byte seen in DATA")
  1806. }
  1807. }
  1808. if df.StreamEnded() {
  1809. break
  1810. }
  1811. }
  1812. if bytes != size {
  1813. t.Errorf("Got %d bytes; want %d", bytes, size)
  1814. }
  1815. if want := int(size / maxFrameSize); frames < want || frames > want*2 {
  1816. t.Errorf("Got %d frames; want %d", frames, size)
  1817. }
  1818. })
  1819. }
  1820. // Test that the handler can't write more than the client allows
  1821. func TestServer_Response_LargeWrite_FlowControlled(t *testing.T) {
  1822. // Make these reads. Before each read, the client adds exactly enough
  1823. // flow-control to satisfy the read. Numbers chosen arbitrarily.
  1824. reads := []int{123, 1, 13, 127}
  1825. size := 0
  1826. for _, n := range reads {
  1827. size += n
  1828. }
  1829. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1830. w.(http.Flusher).Flush()
  1831. n, err := w.Write(bytes.Repeat([]byte("a"), size))
  1832. if err != nil {
  1833. return fmt.Errorf("Write error: %v", err)
  1834. }
  1835. if n != size {
  1836. return fmt.Errorf("wrong size %d from Write", n)
  1837. }
  1838. return nil
  1839. }, func(st *serverTester) {
  1840. // Set the window size to something explicit for this test.
  1841. // It's also how much initial data we expect.
  1842. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, uint32(reads[0])}); err != nil {
  1843. t.Fatal(err)
  1844. }
  1845. st.wantSettingsAck()
  1846. getSlash(st) // make the single request
  1847. hf := st.wantHeaders()
  1848. if hf.StreamEnded() {
  1849. t.Fatal("unexpected END_STREAM flag")
  1850. }
  1851. if !hf.HeadersEnded() {
  1852. t.Fatal("want END_HEADERS flag")
  1853. }
  1854. df := st.wantData()
  1855. if got := len(df.Data()); got != reads[0] {
  1856. t.Fatalf("Initial window size = %d but got DATA with %d bytes", reads[0], got)
  1857. }
  1858. for _, quota := range reads[1:] {
  1859. if err := st.fr.WriteWindowUpdate(1, uint32(quota)); err != nil {
  1860. t.Fatal(err)
  1861. }
  1862. df := st.wantData()
  1863. if int(quota) != len(df.Data()) {
  1864. t.Fatalf("read %d bytes after giving %d quota", len(df.Data()), quota)
  1865. }
  1866. }
  1867. })
  1868. }
  1869. // Test that the handler blocked in a Write is unblocked if the server sends a RST_STREAM.
  1870. func TestServer_Response_RST_Unblocks_LargeWrite(t *testing.T) {
  1871. const size = 1 << 20
  1872. const maxFrameSize = 16 << 10
  1873. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1874. w.(http.Flusher).Flush()
  1875. errc := make(chan error, 1)
  1876. go func() {
  1877. _, err := w.Write(bytes.Repeat([]byte("a"), size))
  1878. errc <- err
  1879. }()
  1880. select {
  1881. case err := <-errc:
  1882. if err == nil {
  1883. return errors.New("unexpected nil error from Write in handler")
  1884. }
  1885. return nil
  1886. case <-time.After(2 * time.Second):
  1887. return errors.New("timeout waiting for Write in handler")
  1888. }
  1889. }, func(st *serverTester) {
  1890. if err := st.fr.WriteSettings(
  1891. Setting{SettingInitialWindowSize, 0},
  1892. Setting{SettingMaxFrameSize, maxFrameSize},
  1893. ); err != nil {
  1894. t.Fatal(err)
  1895. }
  1896. st.wantSettingsAck()
  1897. getSlash(st) // make the single request
  1898. hf := st.wantHeaders()
  1899. if hf.StreamEnded() {
  1900. t.Fatal("unexpected END_STREAM flag")
  1901. }
  1902. if !hf.HeadersEnded() {
  1903. t.Fatal("want END_HEADERS flag")
  1904. }
  1905. if err := st.fr.WriteRSTStream(1, ErrCodeCancel); err != nil {
  1906. t.Fatal(err)
  1907. }
  1908. })
  1909. }
  1910. func TestServer_Response_Empty_Data_Not_FlowControlled(t *testing.T) {
  1911. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1912. w.(http.Flusher).Flush()
  1913. // Nothing; send empty DATA
  1914. return nil
  1915. }, func(st *serverTester) {
  1916. // Handler gets no data quota:
  1917. if err := st.fr.WriteSettings(Setting{SettingInitialWindowSize, 0}); err != nil {
  1918. t.Fatal(err)
  1919. }
  1920. st.wantSettingsAck()
  1921. getSlash(st) // make the single request
  1922. hf := st.wantHeaders()
  1923. if hf.StreamEnded() {
  1924. t.Fatal("unexpected END_STREAM flag")
  1925. }
  1926. if !hf.HeadersEnded() {
  1927. t.Fatal("want END_HEADERS flag")
  1928. }
  1929. df := st.wantData()
  1930. if got := len(df.Data()); got != 0 {
  1931. t.Fatalf("unexpected %d DATA bytes; want 0", got)
  1932. }
  1933. if !df.StreamEnded() {
  1934. t.Fatal("DATA didn't have END_STREAM")
  1935. }
  1936. })
  1937. }
  1938. func TestServer_Response_Automatic100Continue(t *testing.T) {
  1939. const msg = "foo"
  1940. const reply = "bar"
  1941. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  1942. if v := r.Header.Get("Expect"); v != "" {
  1943. t.Errorf("Expect header = %q; want empty", v)
  1944. }
  1945. buf := make([]byte, len(msg))
  1946. // This read should trigger the 100-continue being sent.
  1947. if n, err := io.ReadFull(r.Body, buf); err != nil || n != len(msg) || string(buf) != msg {
  1948. return fmt.Errorf("ReadFull = %q, %v; want %q, nil", buf[:n], err, msg)
  1949. }
  1950. _, err := io.WriteString(w, reply)
  1951. return err
  1952. }, func(st *serverTester) {
  1953. st.writeHeaders(HeadersFrameParam{
  1954. StreamID: 1, // clients send odd numbers
  1955. BlockFragment: st.encodeHeader(":method", "POST", "expect", "100-continue"),
  1956. EndStream: false,
  1957. EndHeaders: true,
  1958. })
  1959. hf := st.wantHeaders()
  1960. if hf.StreamEnded() {
  1961. t.Fatal("unexpected END_STREAM flag")
  1962. }
  1963. if !hf.HeadersEnded() {
  1964. t.Fatal("want END_HEADERS flag")
  1965. }
  1966. goth := st.decodeHeader(hf.HeaderBlockFragment())
  1967. wanth := [][2]string{
  1968. {":status", "100"},
  1969. }
  1970. if !reflect.DeepEqual(goth, wanth) {
  1971. t.Fatalf("Got headers %v; want %v", goth, wanth)
  1972. }
  1973. // Okay, they sent status 100, so we can send our
  1974. // gigantic and/or sensitive "foo" payload now.
  1975. st.writeData(1, true, []byte(msg))
  1976. st.wantWindowUpdate(0, uint32(len(msg)))
  1977. hf = st.wantHeaders()
  1978. if hf.StreamEnded() {
  1979. t.Fatal("expected data to follow")
  1980. }
  1981. if !hf.HeadersEnded() {
  1982. t.Fatal("want END_HEADERS flag")
  1983. }
  1984. goth = st.decodeHeader(hf.HeaderBlockFragment())
  1985. wanth = [][2]string{
  1986. {":status", "200"},
  1987. {"content-type", "text/plain; charset=utf-8"},
  1988. {"content-length", strconv.Itoa(len(reply))},
  1989. }
  1990. if !reflect.DeepEqual(goth, wanth) {
  1991. t.Errorf("Got headers %v; want %v", goth, wanth)
  1992. }
  1993. df := st.wantData()
  1994. if string(df.Data()) != reply {
  1995. t.Errorf("Client read %q; want %q", df.Data(), reply)
  1996. }
  1997. if !df.StreamEnded() {
  1998. t.Errorf("expect data stream end")
  1999. }
  2000. })
  2001. }
  2002. func TestServer_HandlerWriteErrorOnDisconnect(t *testing.T) {
  2003. errc := make(chan error, 1)
  2004. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2005. p := []byte("some data.\n")
  2006. for {
  2007. _, err := w.Write(p)
  2008. if err != nil {
  2009. errc <- err
  2010. return nil
  2011. }
  2012. }
  2013. }, func(st *serverTester) {
  2014. st.writeHeaders(HeadersFrameParam{
  2015. StreamID: 1,
  2016. BlockFragment: st.encodeHeader(),
  2017. EndStream: false,
  2018. EndHeaders: true,
  2019. })
  2020. hf := st.wantHeaders()
  2021. if hf.StreamEnded() {
  2022. t.Fatal("unexpected END_STREAM flag")
  2023. }
  2024. if !hf.HeadersEnded() {
  2025. t.Fatal("want END_HEADERS flag")
  2026. }
  2027. // Close the connection and wait for the handler to (hopefully) notice.
  2028. st.cc.Close()
  2029. select {
  2030. case <-errc:
  2031. case <-time.After(5 * time.Second):
  2032. t.Error("timeout")
  2033. }
  2034. })
  2035. }
  2036. func TestServer_Rejects_Too_Many_Streams(t *testing.T) {
  2037. const testPath = "/some/path"
  2038. inHandler := make(chan uint32)
  2039. leaveHandler := make(chan bool)
  2040. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2041. id := w.(*responseWriter).rws.stream.id
  2042. inHandler <- id
  2043. if id == 1+(defaultMaxStreams+1)*2 && r.URL.Path != testPath {
  2044. t.Errorf("decoded final path as %q; want %q", r.URL.Path, testPath)
  2045. }
  2046. <-leaveHandler
  2047. })
  2048. defer st.Close()
  2049. st.greet()
  2050. nextStreamID := uint32(1)
  2051. streamID := func() uint32 {
  2052. defer func() { nextStreamID += 2 }()
  2053. return nextStreamID
  2054. }
  2055. sendReq := func(id uint32, headers ...string) {
  2056. st.writeHeaders(HeadersFrameParam{
  2057. StreamID: id,
  2058. BlockFragment: st.encodeHeader(headers...),
  2059. EndStream: true,
  2060. EndHeaders: true,
  2061. })
  2062. }
  2063. for i := 0; i < defaultMaxStreams; i++ {
  2064. sendReq(streamID())
  2065. <-inHandler
  2066. }
  2067. defer func() {
  2068. for i := 0; i < defaultMaxStreams; i++ {
  2069. leaveHandler <- true
  2070. }
  2071. }()
  2072. // And this one should cross the limit:
  2073. // (It's also sent as a CONTINUATION, to verify we still track the decoder context,
  2074. // even if we're rejecting it)
  2075. rejectID := streamID()
  2076. headerBlock := st.encodeHeader(":path", testPath)
  2077. frag1, frag2 := headerBlock[:3], headerBlock[3:]
  2078. st.writeHeaders(HeadersFrameParam{
  2079. StreamID: rejectID,
  2080. BlockFragment: frag1,
  2081. EndStream: true,
  2082. EndHeaders: false, // CONTINUATION coming
  2083. })
  2084. if err := st.fr.WriteContinuation(rejectID, true, frag2); err != nil {
  2085. t.Fatal(err)
  2086. }
  2087. st.wantRSTStream(rejectID, ErrCodeProtocol)
  2088. // But let a handler finish:
  2089. leaveHandler <- true
  2090. st.wantHeaders()
  2091. // And now another stream should be able to start:
  2092. goodID := streamID()
  2093. sendReq(goodID, ":path", testPath)
  2094. select {
  2095. case got := <-inHandler:
  2096. if got != goodID {
  2097. t.Errorf("Got stream %d; want %d", got, goodID)
  2098. }
  2099. case <-time.After(3 * time.Second):
  2100. t.Error("timeout waiting for handler")
  2101. }
  2102. }
  2103. // So many response headers that the server needs to use CONTINUATION frames:
  2104. func TestServer_Response_ManyHeaders_With_Continuation(t *testing.T) {
  2105. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2106. h := w.Header()
  2107. for i := 0; i < 5000; i++ {
  2108. h.Set(fmt.Sprintf("x-header-%d", i), fmt.Sprintf("x-value-%d", i))
  2109. }
  2110. return nil
  2111. }, func(st *serverTester) {
  2112. getSlash(st)
  2113. hf := st.wantHeaders()
  2114. if hf.HeadersEnded() {
  2115. t.Fatal("got unwanted END_HEADERS flag")
  2116. }
  2117. n := 0
  2118. for {
  2119. n++
  2120. cf := st.wantContinuation()
  2121. if cf.HeadersEnded() {
  2122. break
  2123. }
  2124. }
  2125. if n < 5 {
  2126. t.Errorf("Only got %d CONTINUATION frames; expected 5+ (currently 6)", n)
  2127. }
  2128. })
  2129. }
  2130. // This previously crashed (reported by Mathieu Lonjaret as observed
  2131. // while using Camlistore) because we got a DATA frame from the client
  2132. // after the handler exited and our logic at the time was wrong,
  2133. // keeping a stream in the map in stateClosed, which tickled an
  2134. // invariant check later when we tried to remove that stream (via
  2135. // defer sc.closeAllStreamsOnConnClose) when the serverConn serve loop
  2136. // ended.
  2137. func TestServer_NoCrash_HandlerClose_Then_ClientClose(t *testing.T) {
  2138. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2139. // nothing
  2140. return nil
  2141. }, func(st *serverTester) {
  2142. st.writeHeaders(HeadersFrameParam{
  2143. StreamID: 1,
  2144. BlockFragment: st.encodeHeader(),
  2145. EndStream: false, // DATA is coming
  2146. EndHeaders: true,
  2147. })
  2148. hf := st.wantHeaders()
  2149. if !hf.HeadersEnded() || !hf.StreamEnded() {
  2150. t.Fatalf("want END_HEADERS+END_STREAM, got %v", hf)
  2151. }
  2152. // Sent when the a Handler closes while a client has
  2153. // indicated it's still sending DATA:
  2154. st.wantRSTStream(1, ErrCodeNo)
  2155. // Now the handler has ended, so it's ended its
  2156. // stream, but the client hasn't closed its side
  2157. // (stateClosedLocal). So send more data and verify
  2158. // it doesn't crash with an internal invariant panic, like
  2159. // it did before.
  2160. st.writeData(1, true, []byte("foo"))
  2161. // Sent after a peer sends data anyway (admittedly the
  2162. // previous RST_STREAM might've still been in-flight),
  2163. // but they'll get the more friendly 'cancel' code
  2164. // first.
  2165. st.wantRSTStream(1, ErrCodeStreamClosed)
  2166. // Set up a bunch of machinery to record the panic we saw
  2167. // previously.
  2168. var (
  2169. panMu sync.Mutex
  2170. panicVal interface{}
  2171. )
  2172. testHookOnPanicMu.Lock()
  2173. testHookOnPanic = func(sc *serverConn, pv interface{}) bool {
  2174. panMu.Lock()
  2175. panicVal = pv
  2176. panMu.Unlock()
  2177. return true
  2178. }
  2179. testHookOnPanicMu.Unlock()
  2180. // Now force the serve loop to end, via closing the connection.
  2181. st.cc.Close()
  2182. select {
  2183. case <-st.sc.doneServing:
  2184. // Loop has exited.
  2185. panMu.Lock()
  2186. got := panicVal
  2187. panMu.Unlock()
  2188. if got != nil {
  2189. t.Errorf("Got panic: %v", got)
  2190. }
  2191. case <-time.After(5 * time.Second):
  2192. t.Error("timeout")
  2193. }
  2194. })
  2195. }
  2196. func TestServer_Rejects_TLS10(t *testing.T) { testRejectTLS(t, tls.VersionTLS10) }
  2197. func TestServer_Rejects_TLS11(t *testing.T) { testRejectTLS(t, tls.VersionTLS11) }
  2198. func testRejectTLS(t *testing.T, max uint16) {
  2199. st := newServerTester(t, nil, func(c *tls.Config) {
  2200. c.MaxVersion = max
  2201. })
  2202. defer st.Close()
  2203. gf := st.wantGoAway()
  2204. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2205. t.Errorf("Got error code %v; want %v", got, want)
  2206. }
  2207. }
  2208. func TestServer_Rejects_TLSBadCipher(t *testing.T) {
  2209. st := newServerTester(t, nil, func(c *tls.Config) {
  2210. // Only list bad ones:
  2211. c.CipherSuites = []uint16{
  2212. tls.TLS_RSA_WITH_RC4_128_SHA,
  2213. tls.TLS_RSA_WITH_3DES_EDE_CBC_SHA,
  2214. tls.TLS_RSA_WITH_AES_128_CBC_SHA,
  2215. tls.TLS_RSA_WITH_AES_256_CBC_SHA,
  2216. tls.TLS_ECDHE_ECDSA_WITH_RC4_128_SHA,
  2217. tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA,
  2218. tls.TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,
  2219. tls.TLS_ECDHE_RSA_WITH_RC4_128_SHA,
  2220. tls.TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,
  2221. tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,
  2222. tls.TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,
  2223. cipher_TLS_RSA_WITH_AES_128_CBC_SHA256,
  2224. }
  2225. })
  2226. defer st.Close()
  2227. gf := st.wantGoAway()
  2228. if got, want := gf.ErrCode, ErrCodeInadequateSecurity; got != want {
  2229. t.Errorf("Got error code %v; want %v", got, want)
  2230. }
  2231. }
  2232. func TestServer_Advertises_Common_Cipher(t *testing.T) {
  2233. const requiredSuite = tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
  2234. st := newServerTester(t, nil, func(c *tls.Config) {
  2235. // Have the client only support the one required by the spec.
  2236. c.CipherSuites = []uint16{requiredSuite}
  2237. }, func(ts *httptest.Server) {
  2238. var srv *http.Server = ts.Config
  2239. // Have the server configured with no specific cipher suites.
  2240. // This tests that Go's defaults include the required one.
  2241. srv.TLSConfig = nil
  2242. })
  2243. defer st.Close()
  2244. st.greet()
  2245. }
  2246. func (st *serverTester) onHeaderField(f hpack.HeaderField) {
  2247. if f.Name == "date" {
  2248. return
  2249. }
  2250. st.decodedHeaders = append(st.decodedHeaders, [2]string{f.Name, f.Value})
  2251. }
  2252. func (st *serverTester) decodeHeader(headerBlock []byte) (pairs [][2]string) {
  2253. st.decodedHeaders = nil
  2254. if _, err := st.hpackDec.Write(headerBlock); err != nil {
  2255. st.t.Fatalf("hpack decoding error: %v", err)
  2256. }
  2257. if err := st.hpackDec.Close(); err != nil {
  2258. st.t.Fatalf("hpack decoding error: %v", err)
  2259. }
  2260. return st.decodedHeaders
  2261. }
  2262. // testServerResponse sets up an idle HTTP/2 connection. The client function should
  2263. // write a single request that must be handled by the handler. This waits up to 5s
  2264. // for client to return, then up to an additional 2s for the handler to return.
  2265. func testServerResponse(t testing.TB,
  2266. handler func(http.ResponseWriter, *http.Request) error,
  2267. client func(*serverTester),
  2268. ) {
  2269. errc := make(chan error, 1)
  2270. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2271. if r.Body == nil {
  2272. t.Fatal("nil Body")
  2273. }
  2274. errc <- handler(w, r)
  2275. })
  2276. defer st.Close()
  2277. donec := make(chan bool)
  2278. go func() {
  2279. defer close(donec)
  2280. st.greet()
  2281. client(st)
  2282. }()
  2283. select {
  2284. case <-donec:
  2285. case <-time.After(5 * time.Second):
  2286. t.Fatal("timeout in client")
  2287. }
  2288. select {
  2289. case err := <-errc:
  2290. if err != nil {
  2291. t.Fatalf("Error in handler: %v", err)
  2292. }
  2293. case <-time.After(2 * time.Second):
  2294. t.Fatal("timeout in handler")
  2295. }
  2296. }
  2297. // readBodyHandler returns an http Handler func that reads len(want)
  2298. // bytes from r.Body and fails t if the contents read were not
  2299. // the value of want.
  2300. func readBodyHandler(t *testing.T, want string) func(w http.ResponseWriter, r *http.Request) {
  2301. return func(w http.ResponseWriter, r *http.Request) {
  2302. buf := make([]byte, len(want))
  2303. _, err := io.ReadFull(r.Body, buf)
  2304. if err != nil {
  2305. t.Error(err)
  2306. return
  2307. }
  2308. if string(buf) != want {
  2309. t.Errorf("read %q; want %q", buf, want)
  2310. }
  2311. }
  2312. }
  2313. // TestServerWithCurl currently fails, hence the LenientCipherSuites test. See:
  2314. // https://github.com/tatsuhiro-t/nghttp2/issues/140 &
  2315. // http://sourceforge.net/p/curl/bugs/1472/
  2316. func TestServerWithCurl(t *testing.T) { testServerWithCurl(t, false) }
  2317. func TestServerWithCurl_LenientCipherSuites(t *testing.T) { testServerWithCurl(t, true) }
  2318. func testServerWithCurl(t *testing.T, permitProhibitedCipherSuites bool) {
  2319. if runtime.GOOS != "linux" {
  2320. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2321. }
  2322. if testing.Short() {
  2323. t.Skip("skipping curl test in short mode")
  2324. }
  2325. requireCurl(t)
  2326. var gotConn int32
  2327. testHookOnConn = func() { atomic.StoreInt32(&gotConn, 1) }
  2328. const msg = "Hello from curl!\n"
  2329. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2330. w.Header().Set("Foo", "Bar")
  2331. w.Header().Set("Client-Proto", r.Proto)
  2332. io.WriteString(w, msg)
  2333. }))
  2334. ConfigureServer(ts.Config, &Server{
  2335. PermitProhibitedCipherSuites: permitProhibitedCipherSuites,
  2336. })
  2337. ts.TLS = ts.Config.TLSConfig // the httptest.Server has its own copy of this TLS config
  2338. ts.StartTLS()
  2339. defer ts.Close()
  2340. t.Logf("Running test server for curl to hit at: %s", ts.URL)
  2341. container := curl(t, "--silent", "--http2", "--insecure", "-v", ts.URL)
  2342. defer kill(container)
  2343. resc := make(chan interface{}, 1)
  2344. go func() {
  2345. res, err := dockerLogs(container)
  2346. if err != nil {
  2347. resc <- err
  2348. } else {
  2349. resc <- res
  2350. }
  2351. }()
  2352. select {
  2353. case res := <-resc:
  2354. if err, ok := res.(error); ok {
  2355. t.Fatal(err)
  2356. }
  2357. body := string(res.([]byte))
  2358. // Search for both "key: value" and "key:value", since curl changed their format
  2359. // Our Dockerfile contains the latest version (no space), but just in case people
  2360. // didn't rebuild, check both.
  2361. if !strings.Contains(body, "foo: Bar") && !strings.Contains(body, "foo:Bar") {
  2362. t.Errorf("didn't see foo: Bar header")
  2363. t.Logf("Got: %s", body)
  2364. }
  2365. if !strings.Contains(body, "client-proto: HTTP/2") && !strings.Contains(body, "client-proto:HTTP/2") {
  2366. t.Errorf("didn't see client-proto: HTTP/2 header")
  2367. t.Logf("Got: %s", res)
  2368. }
  2369. if !strings.Contains(string(res.([]byte)), msg) {
  2370. t.Errorf("didn't see %q content", msg)
  2371. t.Logf("Got: %s", res)
  2372. }
  2373. case <-time.After(3 * time.Second):
  2374. t.Errorf("timeout waiting for curl")
  2375. }
  2376. if atomic.LoadInt32(&gotConn) == 0 {
  2377. t.Error("never saw an http2 connection")
  2378. }
  2379. }
  2380. var doh2load = flag.Bool("h2load", false, "Run h2load test")
  2381. func TestServerWithH2Load(t *testing.T) {
  2382. if !*doh2load {
  2383. t.Skip("Skipping without --h2load flag.")
  2384. }
  2385. if runtime.GOOS != "linux" {
  2386. t.Skip("skipping Docker test when not on Linux; requires --net which won't work with boot2docker anyway")
  2387. }
  2388. requireH2load(t)
  2389. msg := strings.Repeat("Hello, h2load!\n", 5000)
  2390. ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  2391. io.WriteString(w, msg)
  2392. w.(http.Flusher).Flush()
  2393. io.WriteString(w, msg)
  2394. }))
  2395. ts.StartTLS()
  2396. defer ts.Close()
  2397. cmd := exec.Command("docker", "run", "--net=host", "--entrypoint=/usr/local/bin/h2load", "gohttp2/curl",
  2398. "-n100000", "-c100", "-m100", ts.URL)
  2399. cmd.Stdout = os.Stdout
  2400. cmd.Stderr = os.Stderr
  2401. if err := cmd.Run(); err != nil {
  2402. t.Fatal(err)
  2403. }
  2404. }
  2405. // Issue 12843
  2406. func TestServerDoS_MaxHeaderListSize(t *testing.T) {
  2407. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {})
  2408. defer st.Close()
  2409. // shake hands
  2410. frameSize := defaultMaxReadFrameSize
  2411. var advHeaderListSize *uint32
  2412. st.greetAndCheckSettings(func(s Setting) error {
  2413. switch s.ID {
  2414. case SettingMaxFrameSize:
  2415. if s.Val < minMaxFrameSize {
  2416. frameSize = minMaxFrameSize
  2417. } else if s.Val > maxFrameSize {
  2418. frameSize = maxFrameSize
  2419. } else {
  2420. frameSize = int(s.Val)
  2421. }
  2422. case SettingMaxHeaderListSize:
  2423. advHeaderListSize = &s.Val
  2424. }
  2425. return nil
  2426. })
  2427. if advHeaderListSize == nil {
  2428. t.Errorf("server didn't advertise a max header list size")
  2429. } else if *advHeaderListSize == 0 {
  2430. t.Errorf("server advertised a max header list size of 0")
  2431. }
  2432. st.encodeHeaderField(":method", "GET")
  2433. st.encodeHeaderField(":path", "/")
  2434. st.encodeHeaderField(":scheme", "https")
  2435. cookie := strings.Repeat("*", 4058)
  2436. st.encodeHeaderField("cookie", cookie)
  2437. st.writeHeaders(HeadersFrameParam{
  2438. StreamID: 1,
  2439. BlockFragment: st.headerBuf.Bytes(),
  2440. EndStream: true,
  2441. EndHeaders: false,
  2442. })
  2443. // Capture the short encoding of a duplicate ~4K cookie, now
  2444. // that we've already sent it once.
  2445. st.headerBuf.Reset()
  2446. st.encodeHeaderField("cookie", cookie)
  2447. // Now send 1MB of it.
  2448. const size = 1 << 20
  2449. b := bytes.Repeat(st.headerBuf.Bytes(), size/st.headerBuf.Len())
  2450. for len(b) > 0 {
  2451. chunk := b
  2452. if len(chunk) > frameSize {
  2453. chunk = chunk[:frameSize]
  2454. }
  2455. b = b[len(chunk):]
  2456. st.fr.WriteContinuation(1, len(b) == 0, chunk)
  2457. }
  2458. h := st.wantHeaders()
  2459. if !h.HeadersEnded() {
  2460. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2461. }
  2462. headers := st.decodeHeader(h.HeaderBlockFragment())
  2463. want := [][2]string{
  2464. {":status", "431"},
  2465. {"content-type", "text/html; charset=utf-8"},
  2466. {"content-length", "63"},
  2467. }
  2468. if !reflect.DeepEqual(headers, want) {
  2469. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2470. }
  2471. }
  2472. func TestCompressionErrorOnWrite(t *testing.T) {
  2473. const maxStrLen = 8 << 10
  2474. var serverConfig *http.Server
  2475. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2476. // No response body.
  2477. }, func(ts *httptest.Server) {
  2478. serverConfig = ts.Config
  2479. serverConfig.MaxHeaderBytes = maxStrLen
  2480. })
  2481. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2482. defer st.Close()
  2483. st.greet()
  2484. maxAllowed := st.sc.framer.maxHeaderStringLen()
  2485. // Crank this up, now that we have a conn connected with the
  2486. // hpack.Decoder's max string length set has been initialized
  2487. // from the earlier low ~8K value. We want this higher so don't
  2488. // hit the max header list size. We only want to test hitting
  2489. // the max string size.
  2490. serverConfig.MaxHeaderBytes = 1 << 20
  2491. // First a request with a header that's exactly the max allowed size
  2492. // for the hpack compression. It's still too long for the header list
  2493. // size, so we'll get the 431 error, but that keeps the compression
  2494. // context still valid.
  2495. hbf := st.encodeHeader("foo", strings.Repeat("a", maxAllowed))
  2496. st.writeHeaders(HeadersFrameParam{
  2497. StreamID: 1,
  2498. BlockFragment: hbf,
  2499. EndStream: true,
  2500. EndHeaders: true,
  2501. })
  2502. h := st.wantHeaders()
  2503. if !h.HeadersEnded() {
  2504. t.Fatalf("Got HEADERS without END_HEADERS set: %v", h)
  2505. }
  2506. headers := st.decodeHeader(h.HeaderBlockFragment())
  2507. want := [][2]string{
  2508. {":status", "431"},
  2509. {"content-type", "text/html; charset=utf-8"},
  2510. {"content-length", "63"},
  2511. }
  2512. if !reflect.DeepEqual(headers, want) {
  2513. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2514. }
  2515. df := st.wantData()
  2516. if !strings.Contains(string(df.Data()), "HTTP Error 431") {
  2517. t.Errorf("Unexpected data body: %q", df.Data())
  2518. }
  2519. if !df.StreamEnded() {
  2520. t.Fatalf("expect data stream end")
  2521. }
  2522. // And now send one that's just one byte too big.
  2523. hbf = st.encodeHeader("bar", strings.Repeat("b", maxAllowed+1))
  2524. st.writeHeaders(HeadersFrameParam{
  2525. StreamID: 3,
  2526. BlockFragment: hbf,
  2527. EndStream: true,
  2528. EndHeaders: true,
  2529. })
  2530. ga := st.wantGoAway()
  2531. if ga.ErrCode != ErrCodeCompression {
  2532. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2533. }
  2534. }
  2535. func TestCompressionErrorOnClose(t *testing.T) {
  2536. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2537. // No response body.
  2538. })
  2539. st.addLogFilter("connection error: COMPRESSION_ERROR")
  2540. defer st.Close()
  2541. st.greet()
  2542. hbf := st.encodeHeader("foo", "bar")
  2543. hbf = hbf[:len(hbf)-1] // truncate one byte from the end, so hpack.Decoder.Close fails.
  2544. st.writeHeaders(HeadersFrameParam{
  2545. StreamID: 1,
  2546. BlockFragment: hbf,
  2547. EndStream: true,
  2548. EndHeaders: true,
  2549. })
  2550. ga := st.wantGoAway()
  2551. if ga.ErrCode != ErrCodeCompression {
  2552. t.Errorf("GOAWAY err = %v; want ErrCodeCompression", ga.ErrCode)
  2553. }
  2554. }
  2555. // test that a server handler can read trailers from a client
  2556. func TestServerReadsTrailers(t *testing.T) {
  2557. const testBody = "some test body"
  2558. writeReq := func(st *serverTester) {
  2559. st.writeHeaders(HeadersFrameParam{
  2560. StreamID: 1, // clients send odd numbers
  2561. BlockFragment: st.encodeHeader("trailer", "Foo, Bar", "trailer", "Baz"),
  2562. EndStream: false,
  2563. EndHeaders: true,
  2564. })
  2565. st.writeData(1, false, []byte(testBody))
  2566. st.writeHeaders(HeadersFrameParam{
  2567. StreamID: 1, // clients send odd numbers
  2568. BlockFragment: st.encodeHeaderRaw(
  2569. "foo", "foov",
  2570. "bar", "barv",
  2571. "baz", "bazv",
  2572. "surprise", "wasn't declared; shouldn't show up",
  2573. ),
  2574. EndStream: true,
  2575. EndHeaders: true,
  2576. })
  2577. }
  2578. checkReq := func(r *http.Request) {
  2579. wantTrailer := http.Header{
  2580. "Foo": nil,
  2581. "Bar": nil,
  2582. "Baz": nil,
  2583. }
  2584. if !reflect.DeepEqual(r.Trailer, wantTrailer) {
  2585. t.Errorf("initial Trailer = %v; want %v", r.Trailer, wantTrailer)
  2586. }
  2587. slurp, err := ioutil.ReadAll(r.Body)
  2588. if string(slurp) != testBody {
  2589. t.Errorf("read body %q; want %q", slurp, testBody)
  2590. }
  2591. if err != nil {
  2592. t.Fatalf("Body slurp: %v", err)
  2593. }
  2594. wantTrailerAfter := http.Header{
  2595. "Foo": {"foov"},
  2596. "Bar": {"barv"},
  2597. "Baz": {"bazv"},
  2598. }
  2599. if !reflect.DeepEqual(r.Trailer, wantTrailerAfter) {
  2600. t.Errorf("final Trailer = %v; want %v", r.Trailer, wantTrailerAfter)
  2601. }
  2602. }
  2603. testServerRequest(t, writeReq, checkReq)
  2604. }
  2605. // test that a server handler can send trailers
  2606. func TestServerWritesTrailers_WithFlush(t *testing.T) { testServerWritesTrailers(t, true) }
  2607. func TestServerWritesTrailers_WithoutFlush(t *testing.T) { testServerWritesTrailers(t, false) }
  2608. func testServerWritesTrailers(t *testing.T, withFlush bool) {
  2609. // See https://httpwg.github.io/specs/rfc7540.html#rfc.section.8.1.3
  2610. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2611. w.Header().Set("Trailer", "Server-Trailer-A, Server-Trailer-B")
  2612. w.Header().Add("Trailer", "Server-Trailer-C")
  2613. w.Header().Add("Trailer", "Transfer-Encoding, Content-Length, Trailer") // filtered
  2614. // Regular headers:
  2615. w.Header().Set("Foo", "Bar")
  2616. w.Header().Set("Content-Length", "5") // len("Hello")
  2617. io.WriteString(w, "Hello")
  2618. if withFlush {
  2619. w.(http.Flusher).Flush()
  2620. }
  2621. w.Header().Set("Server-Trailer-A", "valuea")
  2622. w.Header().Set("Server-Trailer-C", "valuec") // skipping B
  2623. // After a flush, random keys like Server-Surprise shouldn't show up:
  2624. w.Header().Set("Server-Surpise", "surprise! this isn't predeclared!")
  2625. // But we do permit promoting keys to trailers after a
  2626. // flush if they start with the magic
  2627. // otherwise-invalid "Trailer:" prefix:
  2628. w.Header().Set("Trailer:Post-Header-Trailer", "hi1")
  2629. w.Header().Set("Trailer:post-header-trailer2", "hi2")
  2630. w.Header().Set("Trailer:Range", "invalid")
  2631. w.Header().Set("Trailer:Foo\x01Bogus", "invalid")
  2632. w.Header().Set("Transfer-Encoding", "should not be included; Forbidden by RFC 7230 4.1.2")
  2633. w.Header().Set("Content-Length", "should not be included; Forbidden by RFC 7230 4.1.2")
  2634. w.Header().Set("Trailer", "should not be included; Forbidden by RFC 7230 4.1.2")
  2635. return nil
  2636. }, func(st *serverTester) {
  2637. getSlash(st)
  2638. hf := st.wantHeaders()
  2639. if hf.StreamEnded() {
  2640. t.Fatal("response HEADERS had END_STREAM")
  2641. }
  2642. if !hf.HeadersEnded() {
  2643. t.Fatal("response HEADERS didn't have END_HEADERS")
  2644. }
  2645. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2646. wanth := [][2]string{
  2647. {":status", "200"},
  2648. {"foo", "Bar"},
  2649. {"trailer", "Server-Trailer-A, Server-Trailer-B"},
  2650. {"trailer", "Server-Trailer-C"},
  2651. {"trailer", "Transfer-Encoding, Content-Length, Trailer"},
  2652. {"content-type", "text/plain; charset=utf-8"},
  2653. {"content-length", "5"},
  2654. }
  2655. if !reflect.DeepEqual(goth, wanth) {
  2656. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2657. }
  2658. df := st.wantData()
  2659. if string(df.Data()) != "Hello" {
  2660. t.Fatalf("Client read %q; want Hello", df.Data())
  2661. }
  2662. if df.StreamEnded() {
  2663. t.Fatalf("data frame had STREAM_ENDED")
  2664. }
  2665. tf := st.wantHeaders() // for the trailers
  2666. if !tf.StreamEnded() {
  2667. t.Fatalf("trailers HEADERS lacked END_STREAM")
  2668. }
  2669. if !tf.HeadersEnded() {
  2670. t.Fatalf("trailers HEADERS lacked END_HEADERS")
  2671. }
  2672. wanth = [][2]string{
  2673. {"post-header-trailer", "hi1"},
  2674. {"post-header-trailer2", "hi2"},
  2675. {"server-trailer-a", "valuea"},
  2676. {"server-trailer-c", "valuec"},
  2677. }
  2678. goth = st.decodeHeader(tf.HeaderBlockFragment())
  2679. if !reflect.DeepEqual(goth, wanth) {
  2680. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2681. }
  2682. })
  2683. }
  2684. // validate transmitted header field names & values
  2685. // golang.org/issue/14048
  2686. func TestServerDoesntWriteInvalidHeaders(t *testing.T) {
  2687. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  2688. w.Header().Add("OK1", "x")
  2689. w.Header().Add("Bad:Colon", "x") // colon (non-token byte) in key
  2690. w.Header().Add("Bad1\x00", "x") // null in key
  2691. w.Header().Add("Bad2", "x\x00y") // null in value
  2692. return nil
  2693. }, func(st *serverTester) {
  2694. getSlash(st)
  2695. hf := st.wantHeaders()
  2696. if !hf.StreamEnded() {
  2697. t.Error("response HEADERS lacked END_STREAM")
  2698. }
  2699. if !hf.HeadersEnded() {
  2700. t.Fatal("response HEADERS didn't have END_HEADERS")
  2701. }
  2702. goth := st.decodeHeader(hf.HeaderBlockFragment())
  2703. wanth := [][2]string{
  2704. {":status", "200"},
  2705. {"ok1", "x"},
  2706. {"content-length", "0"},
  2707. }
  2708. if !reflect.DeepEqual(goth, wanth) {
  2709. t.Errorf("Header mismatch.\n got: %v\nwant: %v", goth, wanth)
  2710. }
  2711. })
  2712. }
  2713. func BenchmarkServerGets(b *testing.B) {
  2714. defer disableGoroutineTracking()()
  2715. b.ReportAllocs()
  2716. const msg = "Hello, world"
  2717. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2718. io.WriteString(w, msg)
  2719. })
  2720. defer st.Close()
  2721. st.greet()
  2722. // Give the server quota to reply. (plus it has the 64KB)
  2723. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2724. b.Fatal(err)
  2725. }
  2726. for i := 0; i < b.N; i++ {
  2727. id := 1 + uint32(i)*2
  2728. st.writeHeaders(HeadersFrameParam{
  2729. StreamID: id,
  2730. BlockFragment: st.encodeHeader(),
  2731. EndStream: true,
  2732. EndHeaders: true,
  2733. })
  2734. st.wantHeaders()
  2735. df := st.wantData()
  2736. if !df.StreamEnded() {
  2737. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2738. }
  2739. }
  2740. }
  2741. func BenchmarkServerPosts(b *testing.B) {
  2742. defer disableGoroutineTracking()()
  2743. b.ReportAllocs()
  2744. const msg = "Hello, world"
  2745. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2746. // Consume the (empty) body from th peer before replying, otherwise
  2747. // the server will sometimes (depending on scheduling) send the peer a
  2748. // a RST_STREAM with the CANCEL error code.
  2749. if n, err := io.Copy(ioutil.Discard, r.Body); n != 0 || err != nil {
  2750. b.Errorf("Copy error; got %v, %v; want 0, nil", n, err)
  2751. }
  2752. io.WriteString(w, msg)
  2753. })
  2754. defer st.Close()
  2755. st.greet()
  2756. // Give the server quota to reply. (plus it has the 64KB)
  2757. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  2758. b.Fatal(err)
  2759. }
  2760. for i := 0; i < b.N; i++ {
  2761. id := 1 + uint32(i)*2
  2762. st.writeHeaders(HeadersFrameParam{
  2763. StreamID: id,
  2764. BlockFragment: st.encodeHeader(":method", "POST"),
  2765. EndStream: false,
  2766. EndHeaders: true,
  2767. })
  2768. st.writeData(id, true, nil)
  2769. st.wantHeaders()
  2770. df := st.wantData()
  2771. if !df.StreamEnded() {
  2772. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2773. }
  2774. }
  2775. }
  2776. // Send a stream of messages from server to client in separate data frames.
  2777. // Brings up performance issues seen in long streams.
  2778. // Created to show problem in go issue #18502
  2779. func BenchmarkServerToClientStreamDefaultOptions(b *testing.B) {
  2780. benchmarkServerToClientStream(b)
  2781. }
  2782. // Justification for Change-Id: Iad93420ef6c3918f54249d867098f1dadfa324d8
  2783. // Expect to see memory/alloc reduction by opting in to Frame reuse with the Framer.
  2784. func BenchmarkServerToClientStreamReuseFrames(b *testing.B) {
  2785. benchmarkServerToClientStream(b, optFramerReuseFrames)
  2786. }
  2787. func benchmarkServerToClientStream(b *testing.B, newServerOpts ...interface{}) {
  2788. defer disableGoroutineTracking()()
  2789. b.ReportAllocs()
  2790. const msgLen = 1
  2791. // default window size
  2792. const windowSize = 1<<16 - 1
  2793. // next message to send from the server and for the client to expect
  2794. nextMsg := func(i int) []byte {
  2795. msg := make([]byte, msgLen)
  2796. msg[0] = byte(i)
  2797. if len(msg) != msgLen {
  2798. panic("invalid test setup msg length")
  2799. }
  2800. return msg
  2801. }
  2802. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  2803. // Consume the (empty) body from th peer before replying, otherwise
  2804. // the server will sometimes (depending on scheduling) send the peer a
  2805. // a RST_STREAM with the CANCEL error code.
  2806. if n, err := io.Copy(ioutil.Discard, r.Body); n != 0 || err != nil {
  2807. b.Errorf("Copy error; got %v, %v; want 0, nil", n, err)
  2808. }
  2809. for i := 0; i < b.N; i += 1 {
  2810. w.Write(nextMsg(i))
  2811. w.(http.Flusher).Flush()
  2812. }
  2813. }, newServerOpts...)
  2814. defer st.Close()
  2815. st.greet()
  2816. const id = uint32(1)
  2817. st.writeHeaders(HeadersFrameParam{
  2818. StreamID: id,
  2819. BlockFragment: st.encodeHeader(":method", "POST"),
  2820. EndStream: false,
  2821. EndHeaders: true,
  2822. })
  2823. st.writeData(id, true, nil)
  2824. st.wantHeaders()
  2825. var pendingWindowUpdate = uint32(0)
  2826. for i := 0; i < b.N; i += 1 {
  2827. expected := nextMsg(i)
  2828. df := st.wantData()
  2829. if bytes.Compare(expected, df.data) != 0 {
  2830. b.Fatalf("Bad message received; want %v; got %v", expected, df.data)
  2831. }
  2832. // try to send infrequent but large window updates so they don't overwhelm the test
  2833. pendingWindowUpdate += uint32(len(df.data))
  2834. if pendingWindowUpdate >= windowSize/2 {
  2835. if err := st.fr.WriteWindowUpdate(0, pendingWindowUpdate); err != nil {
  2836. b.Fatal(err)
  2837. }
  2838. if err := st.fr.WriteWindowUpdate(id, pendingWindowUpdate); err != nil {
  2839. b.Fatal(err)
  2840. }
  2841. pendingWindowUpdate = 0
  2842. }
  2843. }
  2844. df := st.wantData()
  2845. if !df.StreamEnded() {
  2846. b.Fatalf("DATA didn't have END_STREAM; got %v", df)
  2847. }
  2848. }
  2849. // go-fuzz bug, originally reported at https://github.com/bradfitz/http2/issues/53
  2850. // Verify we don't hang.
  2851. func TestIssue53(t *testing.T) {
  2852. const data = "PRI * HTTP/2.0\r\n\r\nSM" +
  2853. "\r\n\r\n\x00\x00\x00\x01\ainfinfin\ad"
  2854. s := &http.Server{
  2855. ErrorLog: log.New(io.MultiWriter(stderrv(), twriter{t: t}), "", log.LstdFlags),
  2856. Handler: http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
  2857. w.Write([]byte("hello"))
  2858. }),
  2859. }
  2860. s2 := &Server{
  2861. MaxReadFrameSize: 1 << 16,
  2862. PermitProhibitedCipherSuites: true,
  2863. }
  2864. c := &issue53Conn{[]byte(data), false, false}
  2865. s2.ServeConn(c, &ServeConnOpts{BaseConfig: s})
  2866. if !c.closed {
  2867. t.Fatal("connection is not closed")
  2868. }
  2869. }
  2870. type issue53Conn struct {
  2871. data []byte
  2872. closed bool
  2873. written bool
  2874. }
  2875. func (c *issue53Conn) Read(b []byte) (n int, err error) {
  2876. if len(c.data) == 0 {
  2877. return 0, io.EOF
  2878. }
  2879. n = copy(b, c.data)
  2880. c.data = c.data[n:]
  2881. return
  2882. }
  2883. func (c *issue53Conn) Write(b []byte) (n int, err error) {
  2884. c.written = true
  2885. return len(b), nil
  2886. }
  2887. func (c *issue53Conn) Close() error {
  2888. c.closed = true
  2889. return nil
  2890. }
  2891. func (c *issue53Conn) LocalAddr() net.Addr {
  2892. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2893. }
  2894. func (c *issue53Conn) RemoteAddr() net.Addr {
  2895. return &net.TCPAddr{IP: net.IPv4(127, 0, 0, 1), Port: 49706}
  2896. }
  2897. func (c *issue53Conn) SetDeadline(t time.Time) error { return nil }
  2898. func (c *issue53Conn) SetReadDeadline(t time.Time) error { return nil }
  2899. func (c *issue53Conn) SetWriteDeadline(t time.Time) error { return nil }
  2900. // golang.org/issue/12895
  2901. func TestConfigureServer(t *testing.T) {
  2902. tests := []struct {
  2903. name string
  2904. tlsConfig *tls.Config
  2905. wantErr string
  2906. }{
  2907. {
  2908. name: "empty server",
  2909. },
  2910. {
  2911. name: "just the required cipher suite",
  2912. tlsConfig: &tls.Config{
  2913. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2914. },
  2915. },
  2916. {
  2917. name: "just the alternative required cipher suite",
  2918. tlsConfig: &tls.Config{
  2919. CipherSuites: []uint16{tls.TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256},
  2920. },
  2921. },
  2922. {
  2923. name: "missing required cipher suite",
  2924. tlsConfig: &tls.Config{
  2925. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384},
  2926. },
  2927. wantErr: "is missing an HTTP/2-required AES_128_GCM_SHA256 cipher.",
  2928. },
  2929. {
  2930. name: "required after bad",
  2931. tlsConfig: &tls.Config{
  2932. CipherSuites: []uint16{tls.TLS_RSA_WITH_RC4_128_SHA, tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256},
  2933. },
  2934. wantErr: "contains an HTTP/2-approved cipher suite (0xc02f), but it comes after",
  2935. },
  2936. {
  2937. name: "bad after required",
  2938. tlsConfig: &tls.Config{
  2939. CipherSuites: []uint16{tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, tls.TLS_RSA_WITH_RC4_128_SHA},
  2940. },
  2941. },
  2942. }
  2943. for _, tt := range tests {
  2944. srv := &http.Server{TLSConfig: tt.tlsConfig}
  2945. err := ConfigureServer(srv, nil)
  2946. if (err != nil) != (tt.wantErr != "") {
  2947. if tt.wantErr != "" {
  2948. t.Errorf("%s: success, but want error", tt.name)
  2949. } else {
  2950. t.Errorf("%s: unexpected error: %v", tt.name, err)
  2951. }
  2952. }
  2953. if err != nil && tt.wantErr != "" && !strings.Contains(err.Error(), tt.wantErr) {
  2954. t.Errorf("%s: err = %v; want substring %q", tt.name, err, tt.wantErr)
  2955. }
  2956. if err == nil && !srv.TLSConfig.PreferServerCipherSuites {
  2957. t.Errorf("%s: PreferServerCipherSuite is false; want true", tt.name)
  2958. }
  2959. }
  2960. }
  2961. func TestServerRejectHeadWithBody(t *testing.T) {
  2962. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2963. // No response body.
  2964. })
  2965. defer st.Close()
  2966. st.greet()
  2967. st.writeHeaders(HeadersFrameParam{
  2968. StreamID: 1, // clients send odd numbers
  2969. BlockFragment: st.encodeHeader(":method", "HEAD"),
  2970. EndStream: false, // what we're testing, a bogus HEAD request with body
  2971. EndHeaders: true,
  2972. })
  2973. st.wantRSTStream(1, ErrCodeProtocol)
  2974. }
  2975. func TestServerNoAutoContentLengthOnHead(t *testing.T) {
  2976. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2977. // No response body. (or smaller than one frame)
  2978. })
  2979. defer st.Close()
  2980. st.greet()
  2981. st.writeHeaders(HeadersFrameParam{
  2982. StreamID: 1, // clients send odd numbers
  2983. BlockFragment: st.encodeHeader(":method", "HEAD"),
  2984. EndStream: true,
  2985. EndHeaders: true,
  2986. })
  2987. h := st.wantHeaders()
  2988. headers := st.decodeHeader(h.HeaderBlockFragment())
  2989. want := [][2]string{
  2990. {":status", "200"},
  2991. }
  2992. if !reflect.DeepEqual(headers, want) {
  2993. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  2994. }
  2995. }
  2996. // golang.org/issue/13495
  2997. func TestServerNoDuplicateContentType(t *testing.T) {
  2998. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  2999. w.Header()["Content-Type"] = []string{""}
  3000. fmt.Fprintf(w, "<html><head></head><body>hi</body></html>")
  3001. })
  3002. defer st.Close()
  3003. st.greet()
  3004. st.writeHeaders(HeadersFrameParam{
  3005. StreamID: 1,
  3006. BlockFragment: st.encodeHeader(),
  3007. EndStream: true,
  3008. EndHeaders: true,
  3009. })
  3010. h := st.wantHeaders()
  3011. headers := st.decodeHeader(h.HeaderBlockFragment())
  3012. want := [][2]string{
  3013. {":status", "200"},
  3014. {"content-type", ""},
  3015. {"content-length", "41"},
  3016. }
  3017. if !reflect.DeepEqual(headers, want) {
  3018. t.Errorf("Headers mismatch.\n got: %q\nwant: %q\n", headers, want)
  3019. }
  3020. }
  3021. func disableGoroutineTracking() (restore func()) {
  3022. old := DebugGoroutines
  3023. DebugGoroutines = false
  3024. return func() { DebugGoroutines = old }
  3025. }
  3026. func BenchmarkServer_GetRequest(b *testing.B) {
  3027. defer disableGoroutineTracking()()
  3028. b.ReportAllocs()
  3029. const msg = "Hello, world."
  3030. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  3031. n, err := io.Copy(ioutil.Discard, r.Body)
  3032. if err != nil || n > 0 {
  3033. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  3034. }
  3035. io.WriteString(w, msg)
  3036. })
  3037. defer st.Close()
  3038. st.greet()
  3039. // Give the server quota to reply. (plus it has the 64KB)
  3040. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  3041. b.Fatal(err)
  3042. }
  3043. hbf := st.encodeHeader(":method", "GET")
  3044. for i := 0; i < b.N; i++ {
  3045. streamID := uint32(1 + 2*i)
  3046. st.writeHeaders(HeadersFrameParam{
  3047. StreamID: streamID,
  3048. BlockFragment: hbf,
  3049. EndStream: true,
  3050. EndHeaders: true,
  3051. })
  3052. st.wantHeaders()
  3053. st.wantData()
  3054. }
  3055. }
  3056. func BenchmarkServer_PostRequest(b *testing.B) {
  3057. defer disableGoroutineTracking()()
  3058. b.ReportAllocs()
  3059. const msg = "Hello, world."
  3060. st := newServerTester(b, func(w http.ResponseWriter, r *http.Request) {
  3061. n, err := io.Copy(ioutil.Discard, r.Body)
  3062. if err != nil || n > 0 {
  3063. b.Errorf("Read %d bytes, error %v; want 0 bytes.", n, err)
  3064. }
  3065. io.WriteString(w, msg)
  3066. })
  3067. defer st.Close()
  3068. st.greet()
  3069. // Give the server quota to reply. (plus it has the 64KB)
  3070. if err := st.fr.WriteWindowUpdate(0, uint32(b.N*len(msg))); err != nil {
  3071. b.Fatal(err)
  3072. }
  3073. hbf := st.encodeHeader(":method", "POST")
  3074. for i := 0; i < b.N; i++ {
  3075. streamID := uint32(1 + 2*i)
  3076. st.writeHeaders(HeadersFrameParam{
  3077. StreamID: streamID,
  3078. BlockFragment: hbf,
  3079. EndStream: false,
  3080. EndHeaders: true,
  3081. })
  3082. st.writeData(streamID, true, nil)
  3083. st.wantHeaders()
  3084. st.wantData()
  3085. }
  3086. }
  3087. type connStateConn struct {
  3088. net.Conn
  3089. cs tls.ConnectionState
  3090. }
  3091. func (c connStateConn) ConnectionState() tls.ConnectionState { return c.cs }
  3092. // golang.org/issue/12737 -- handle any net.Conn, not just
  3093. // *tls.Conn.
  3094. func TestServerHandleCustomConn(t *testing.T) {
  3095. var s Server
  3096. c1, c2 := net.Pipe()
  3097. clientDone := make(chan struct{})
  3098. handlerDone := make(chan struct{})
  3099. var req *http.Request
  3100. go func() {
  3101. defer close(clientDone)
  3102. defer c2.Close()
  3103. fr := NewFramer(c2, c2)
  3104. io.WriteString(c2, ClientPreface)
  3105. fr.WriteSettings()
  3106. fr.WriteSettingsAck()
  3107. f, err := fr.ReadFrame()
  3108. if err != nil {
  3109. t.Error(err)
  3110. return
  3111. }
  3112. if sf, ok := f.(*SettingsFrame); !ok || sf.IsAck() {
  3113. t.Errorf("Got %v; want non-ACK SettingsFrame", summarizeFrame(f))
  3114. return
  3115. }
  3116. f, err = fr.ReadFrame()
  3117. if err != nil {
  3118. t.Error(err)
  3119. return
  3120. }
  3121. if sf, ok := f.(*SettingsFrame); !ok || !sf.IsAck() {
  3122. t.Errorf("Got %v; want ACK SettingsFrame", summarizeFrame(f))
  3123. return
  3124. }
  3125. var henc hpackEncoder
  3126. fr.WriteHeaders(HeadersFrameParam{
  3127. StreamID: 1,
  3128. BlockFragment: henc.encodeHeaderRaw(t, ":method", "GET", ":path", "/", ":scheme", "https", ":authority", "foo.com"),
  3129. EndStream: true,
  3130. EndHeaders: true,
  3131. })
  3132. go io.Copy(ioutil.Discard, c2)
  3133. <-handlerDone
  3134. }()
  3135. const testString = "my custom ConnectionState"
  3136. fakeConnState := tls.ConnectionState{
  3137. ServerName: testString,
  3138. Version: tls.VersionTLS12,
  3139. CipherSuite: cipher_TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
  3140. }
  3141. go s.ServeConn(connStateConn{c1, fakeConnState}, &ServeConnOpts{
  3142. BaseConfig: &http.Server{
  3143. Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
  3144. defer close(handlerDone)
  3145. req = r
  3146. }),
  3147. }})
  3148. select {
  3149. case <-clientDone:
  3150. case <-time.After(5 * time.Second):
  3151. t.Fatal("timeout waiting for handler")
  3152. }
  3153. if req.TLS == nil {
  3154. t.Fatalf("Request.TLS is nil. Got: %#v", req)
  3155. }
  3156. if req.TLS.ServerName != testString {
  3157. t.Fatalf("Request.TLS = %+v; want ServerName of %q", req.TLS, testString)
  3158. }
  3159. }
  3160. // golang.org/issue/14214
  3161. func TestServer_Rejects_ConnHeaders(t *testing.T) {
  3162. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3163. t.Error("should not get to Handler")
  3164. })
  3165. defer st.Close()
  3166. st.greet()
  3167. st.bodylessReq1("connection", "foo")
  3168. hf := st.wantHeaders()
  3169. goth := st.decodeHeader(hf.HeaderBlockFragment())
  3170. wanth := [][2]string{
  3171. {":status", "400"},
  3172. {"content-type", "text/plain; charset=utf-8"},
  3173. {"x-content-type-options", "nosniff"},
  3174. {"content-length", "51"},
  3175. }
  3176. if !reflect.DeepEqual(goth, wanth) {
  3177. t.Errorf("Got headers %v; want %v", goth, wanth)
  3178. }
  3179. }
  3180. type hpackEncoder struct {
  3181. enc *hpack.Encoder
  3182. buf bytes.Buffer
  3183. }
  3184. func (he *hpackEncoder) encodeHeaderRaw(t *testing.T, headers ...string) []byte {
  3185. if len(headers)%2 == 1 {
  3186. panic("odd number of kv args")
  3187. }
  3188. he.buf.Reset()
  3189. if he.enc == nil {
  3190. he.enc = hpack.NewEncoder(&he.buf)
  3191. }
  3192. for len(headers) > 0 {
  3193. k, v := headers[0], headers[1]
  3194. err := he.enc.WriteField(hpack.HeaderField{Name: k, Value: v})
  3195. if err != nil {
  3196. t.Fatalf("HPACK encoding error for %q/%q: %v", k, v, err)
  3197. }
  3198. headers = headers[2:]
  3199. }
  3200. return he.buf.Bytes()
  3201. }
  3202. func TestCheckValidHTTP2Request(t *testing.T) {
  3203. tests := []struct {
  3204. h http.Header
  3205. want error
  3206. }{
  3207. {
  3208. h: http.Header{"Te": {"trailers"}},
  3209. want: nil,
  3210. },
  3211. {
  3212. h: http.Header{"Te": {"trailers", "bogus"}},
  3213. want: errors.New(`request header "TE" may only be "trailers" in HTTP/2`),
  3214. },
  3215. {
  3216. h: http.Header{"Foo": {""}},
  3217. want: nil,
  3218. },
  3219. {
  3220. h: http.Header{"Connection": {""}},
  3221. want: errors.New(`request header "Connection" is not valid in HTTP/2`),
  3222. },
  3223. {
  3224. h: http.Header{"Proxy-Connection": {""}},
  3225. want: errors.New(`request header "Proxy-Connection" is not valid in HTTP/2`),
  3226. },
  3227. {
  3228. h: http.Header{"Keep-Alive": {""}},
  3229. want: errors.New(`request header "Keep-Alive" is not valid in HTTP/2`),
  3230. },
  3231. {
  3232. h: http.Header{"Upgrade": {""}},
  3233. want: errors.New(`request header "Upgrade" is not valid in HTTP/2`),
  3234. },
  3235. }
  3236. for i, tt := range tests {
  3237. got := checkValidHTTP2RequestHeaders(tt.h)
  3238. if !reflect.DeepEqual(got, tt.want) {
  3239. t.Errorf("%d. checkValidHTTP2Request = %v; want %v", i, got, tt.want)
  3240. }
  3241. }
  3242. }
  3243. // golang.org/issue/14030
  3244. func TestExpect100ContinueAfterHandlerWrites(t *testing.T) {
  3245. const msg = "Hello"
  3246. const msg2 = "World"
  3247. doRead := make(chan bool, 1)
  3248. defer close(doRead) // fallback cleanup
  3249. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3250. io.WriteString(w, msg)
  3251. w.(http.Flusher).Flush()
  3252. // Do a read, which might force a 100-continue status to be sent.
  3253. <-doRead
  3254. r.Body.Read(make([]byte, 10))
  3255. io.WriteString(w, msg2)
  3256. }, optOnlyServer)
  3257. defer st.Close()
  3258. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3259. defer tr.CloseIdleConnections()
  3260. req, _ := http.NewRequest("POST", st.ts.URL, io.LimitReader(neverEnding('A'), 2<<20))
  3261. req.Header.Set("Expect", "100-continue")
  3262. res, err := tr.RoundTrip(req)
  3263. if err != nil {
  3264. t.Fatal(err)
  3265. }
  3266. defer res.Body.Close()
  3267. buf := make([]byte, len(msg))
  3268. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3269. t.Fatal(err)
  3270. }
  3271. if string(buf) != msg {
  3272. t.Fatalf("msg = %q; want %q", buf, msg)
  3273. }
  3274. doRead <- true
  3275. if _, err := io.ReadFull(res.Body, buf); err != nil {
  3276. t.Fatal(err)
  3277. }
  3278. if string(buf) != msg2 {
  3279. t.Fatalf("second msg = %q; want %q", buf, msg2)
  3280. }
  3281. }
  3282. type funcReader func([]byte) (n int, err error)
  3283. func (f funcReader) Read(p []byte) (n int, err error) { return f(p) }
  3284. // golang.org/issue/16481 -- return flow control when streams close with unread data.
  3285. // (The Server version of the bug. See also TestUnreadFlowControlReturned_Transport)
  3286. func TestUnreadFlowControlReturned_Server(t *testing.T) {
  3287. unblock := make(chan bool, 1)
  3288. defer close(unblock)
  3289. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3290. // Don't read the 16KB request body. Wait until the client's
  3291. // done sending it and then return. This should cause the Server
  3292. // to then return those 16KB of flow control to the client.
  3293. <-unblock
  3294. }, optOnlyServer)
  3295. defer st.Close()
  3296. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3297. defer tr.CloseIdleConnections()
  3298. // This previously hung on the 4th iteration.
  3299. for i := 0; i < 6; i++ {
  3300. body := io.MultiReader(
  3301. io.LimitReader(neverEnding('A'), 16<<10),
  3302. funcReader(func([]byte) (n int, err error) {
  3303. unblock <- true
  3304. return 0, io.EOF
  3305. }),
  3306. )
  3307. req, _ := http.NewRequest("POST", st.ts.URL, body)
  3308. res, err := tr.RoundTrip(req)
  3309. if err != nil {
  3310. t.Fatal(err)
  3311. }
  3312. res.Body.Close()
  3313. }
  3314. }
  3315. func TestServerIdleTimeout(t *testing.T) {
  3316. if testing.Short() {
  3317. t.Skip("skipping in short mode")
  3318. }
  3319. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3320. }, func(h2s *Server) {
  3321. h2s.IdleTimeout = 500 * time.Millisecond
  3322. })
  3323. defer st.Close()
  3324. st.greet()
  3325. ga := st.wantGoAway()
  3326. if ga.ErrCode != ErrCodeNo {
  3327. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3328. }
  3329. }
  3330. func TestServerIdleTimeout_AfterRequest(t *testing.T) {
  3331. if testing.Short() {
  3332. t.Skip("skipping in short mode")
  3333. }
  3334. const timeout = 250 * time.Millisecond
  3335. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3336. time.Sleep(timeout * 2)
  3337. }, func(h2s *Server) {
  3338. h2s.IdleTimeout = timeout
  3339. })
  3340. defer st.Close()
  3341. st.greet()
  3342. // Send a request which takes twice the timeout. Verifies the
  3343. // idle timeout doesn't fire while we're in a request:
  3344. st.bodylessReq1()
  3345. st.wantHeaders()
  3346. // But the idle timeout should be rearmed after the request
  3347. // is done:
  3348. ga := st.wantGoAway()
  3349. if ga.ErrCode != ErrCodeNo {
  3350. t.Errorf("GOAWAY error = %v; want ErrCodeNo", ga.ErrCode)
  3351. }
  3352. }
  3353. // grpc-go closes the Request.Body currently with a Read.
  3354. // Verify that it doesn't race.
  3355. // See https://github.com/grpc/grpc-go/pull/938
  3356. func TestRequestBodyReadCloseRace(t *testing.T) {
  3357. for i := 0; i < 100; i++ {
  3358. body := &requestBody{
  3359. pipe: &pipe{
  3360. b: new(bytes.Buffer),
  3361. },
  3362. }
  3363. body.pipe.CloseWithError(io.EOF)
  3364. done := make(chan bool, 1)
  3365. buf := make([]byte, 10)
  3366. go func() {
  3367. time.Sleep(1 * time.Millisecond)
  3368. body.Close()
  3369. done <- true
  3370. }()
  3371. body.Read(buf)
  3372. <-done
  3373. }
  3374. }
  3375. func TestIssue20704Race(t *testing.T) {
  3376. if testing.Short() && os.Getenv("GO_BUILDER_NAME") == "" {
  3377. t.Skip("skipping in short mode")
  3378. }
  3379. const (
  3380. itemSize = 1 << 10
  3381. itemCount = 100
  3382. )
  3383. st := newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3384. for i := 0; i < itemCount; i++ {
  3385. _, err := w.Write(make([]byte, itemSize))
  3386. if err != nil {
  3387. return
  3388. }
  3389. }
  3390. }, optOnlyServer)
  3391. defer st.Close()
  3392. tr := &Transport{TLSClientConfig: tlsConfigInsecure}
  3393. defer tr.CloseIdleConnections()
  3394. cl := &http.Client{Transport: tr}
  3395. for i := 0; i < 1000; i++ {
  3396. resp, err := cl.Get(st.ts.URL)
  3397. if err != nil {
  3398. t.Fatal(err)
  3399. }
  3400. // Force a RST stream to the server by closing without
  3401. // reading the body:
  3402. resp.Body.Close()
  3403. }
  3404. }
  3405. func TestServer_Rejects_TooSmall(t *testing.T) {
  3406. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  3407. ioutil.ReadAll(r.Body)
  3408. return nil
  3409. }, func(st *serverTester) {
  3410. st.writeHeaders(HeadersFrameParam{
  3411. StreamID: 1, // clients send odd numbers
  3412. BlockFragment: st.encodeHeader(
  3413. ":method", "POST",
  3414. "content-length", "4",
  3415. ),
  3416. EndStream: false, // to say DATA frames are coming
  3417. EndHeaders: true,
  3418. })
  3419. st.writeData(1, true, []byte("12345"))
  3420. st.wantRSTStream(1, ErrCodeProtocol)
  3421. })
  3422. }
  3423. // Tests that a handler setting "Connection: close" results in a GOAWAY being sent,
  3424. // and the connection still completing.
  3425. func TestServerHandlerConnectionClose(t *testing.T) {
  3426. unblockHandler := make(chan bool, 1)
  3427. defer close(unblockHandler) // backup; in case of errors
  3428. testServerResponse(t, func(w http.ResponseWriter, r *http.Request) error {
  3429. w.Header().Set("Connection", "close")
  3430. w.Header().Set("Foo", "bar")
  3431. w.(http.Flusher).Flush()
  3432. <-unblockHandler
  3433. return nil
  3434. }, func(st *serverTester) {
  3435. st.writeHeaders(HeadersFrameParam{
  3436. StreamID: 1,
  3437. BlockFragment: st.encodeHeader(),
  3438. EndStream: true,
  3439. EndHeaders: true,
  3440. })
  3441. var sawGoAway bool
  3442. var sawRes bool
  3443. for {
  3444. f, err := st.readFrame()
  3445. if err == io.EOF {
  3446. break
  3447. }
  3448. if err != nil {
  3449. t.Fatal(err)
  3450. }
  3451. switch f := f.(type) {
  3452. case *GoAwayFrame:
  3453. sawGoAway = true
  3454. unblockHandler <- true
  3455. if f.LastStreamID != 1 || f.ErrCode != ErrCodeNo {
  3456. t.Errorf("unexpected GOAWAY frame: %v", summarizeFrame(f))
  3457. }
  3458. case *HeadersFrame:
  3459. goth := st.decodeHeader(f.HeaderBlockFragment())
  3460. wanth := [][2]string{
  3461. {":status", "200"},
  3462. {"foo", "bar"},
  3463. }
  3464. if !reflect.DeepEqual(goth, wanth) {
  3465. t.Errorf("got headers %v; want %v", goth, wanth)
  3466. }
  3467. sawRes = true
  3468. case *DataFrame:
  3469. if f.StreamID != 1 || !f.StreamEnded() || len(f.Data()) != 0 {
  3470. t.Errorf("unexpected DATA frame: %v", summarizeFrame(f))
  3471. }
  3472. default:
  3473. t.Logf("unexpected frame: %v", summarizeFrame(f))
  3474. }
  3475. }
  3476. if !sawGoAway {
  3477. t.Errorf("didn't see GOAWAY")
  3478. }
  3479. if !sawRes {
  3480. t.Errorf("didn't see response")
  3481. }
  3482. })
  3483. }
  3484. func TestServer_Headers_HalfCloseRemote(t *testing.T) {
  3485. var st *serverTester
  3486. writeData := make(chan bool)
  3487. writeHeaders := make(chan bool)
  3488. leaveHandler := make(chan bool)
  3489. st = newServerTester(t, func(w http.ResponseWriter, r *http.Request) {
  3490. if st.stream(1) == nil {
  3491. t.Errorf("nil stream 1 in handler")
  3492. }
  3493. if got, want := st.streamState(1), stateOpen; got != want {
  3494. t.Errorf("in handler, state is %v; want %v", got, want)
  3495. }
  3496. writeData <- true
  3497. if n, err := r.Body.Read(make([]byte, 1)); n != 0 || err != io.EOF {
  3498. t.Errorf("body read = %d, %v; want 0, EOF", n, err)
  3499. }
  3500. if got, want := st.streamState(1), stateHalfClosedRemote; got != want {
  3501. t.Errorf("in handler, state is %v; want %v", got, want)
  3502. }
  3503. writeHeaders <- true
  3504. <-leaveHandler
  3505. })
  3506. st.greet()
  3507. st.writeHeaders(HeadersFrameParam{
  3508. StreamID: 1,
  3509. BlockFragment: st.encodeHeader(),
  3510. EndStream: false, // keep it open
  3511. EndHeaders: true,
  3512. })
  3513. <-writeData
  3514. st.writeData(1, true, nil)
  3515. <-writeHeaders
  3516. st.writeHeaders(HeadersFrameParam{
  3517. StreamID: 1,
  3518. BlockFragment: st.encodeHeader(),
  3519. EndStream: false, // keep it open
  3520. EndHeaders: true,
  3521. })
  3522. defer close(leaveHandler)
  3523. st.wantRSTStream(1, ErrCodeStreamClosed)
  3524. }